emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-27 c881e99: * lisp/emacs-lisp/gv.el (edebug-after): Don't run the


From: Stefan Monnier
Subject: emacs-27 c881e99: * lisp/emacs-lisp/gv.el (edebug-after): Don't run the getter in the setter
Date: Fri, 5 Mar 2021 12:39:33 -0500 (EST)

branch: emacs-27
commit c881e990e3a083d7c8b990a2004a3ae82b886b9d
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    * lisp/emacs-lisp/gv.el (edebug-after): Don't run the getter in the setter
    
    This fixes bug#46573 which was introduced by commit
    d79cf638f278e50c22feb53d6ba556f5ce9d7853.
    The new code is a middle ground, which makes sure the instrumentation
    point is used (so the coverage checker won't have ghost unreachable
    instrumentation points) yet without artificially running the getter
    when we only need to run the setter.
---
 lisp/emacs-lisp/gv.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/gv.el b/lisp/emacs-lisp/gv.el
index 4d2bcbf..c9eac70 100644
--- a/lisp/emacs-lisp/gv.el
+++ b/lisp/emacs-lisp/gv.el
@@ -306,8 +306,7 @@ The return value is the last VAL in the list.
        (gv-letplace (getter setter) place
          (funcall do `(edebug-after ,before ,index ,getter)
                   (lambda (store)
-                    `(progn (edebug-after ,before ,index ,getter)
-                            ,(funcall setter store)))))))
+                    `(edebug-after ,before ,index ,(funcall setter store)))))))
 
 ;;; The common generalized variables.
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]