[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master e6299d2783f: Fix unstable proced test
From: |
Mattias Engdegård |
Subject: |
master e6299d2783f: Fix unstable proced test |
Date: |
Sun, 28 May 2023 07:36:08 -0400 (EDT) |
branch: master
commit e6299d2783f9aef4b0b9105650e06166ea5ed2d6
Author: Laurence Warne <laurencewarne@gmail.com>
Commit: Mattias Engdegård <mattiase@acm.org>
Fix unstable proced test
Fix unstable proced test by omitting the revert parameter in
'proced-update'. This was caused by the process being refined on
exiting between the initial 'proced' call and the successive
'proced-update' call. This resulted in proced skipping the refinement
in 'proced-update', causing all processes to be shown again and the
test to fail.
* test/lisp/proced-tests.el (proced-refine-with-update-test): Do not
use revert parameter when calling 'proced-update'.
---
test/lisp/proced-tests.el | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/test/lisp/proced-tests.el b/test/lisp/proced-tests.el
index d69414cf43a..d53f25b00d8 100644
--- a/test/lisp/proced-tests.el
+++ b/test/lisp/proced-tests.el
@@ -89,14 +89,17 @@
(forward-line)))))
(ert-deftest proced-refine-with-update-test ()
- :tags '(:unstable) ; There seems to be an update race here.
(proced--within-buffer
'medium
'user
(proced--move-to-column "PID")
(let ((pid (word-at-point)))
(proced-refine)
- (proced-update t)
+ ;; Don't use (proced-update t) since this will reset
`proced-process-alist'
+ ;; and it's possible the process refined on would have exited by that
+ ;; point. In this case proced will skip the refinement and show all
+ ;; processes again, causing the test to fail.
+ (proced-update)
(while (not (eobp))
(proced--move-to-column "PID")
(should (string= pid (word-at-point)))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- master e6299d2783f: Fix unstable proced test,
Mattias Engdegård <=