[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
emacs-29 0d8b69e0ad3: Don't ding when completion succeeded
From: |
Eli Zaretskii |
Subject: |
emacs-29 0d8b69e0ad3: Don't ding when completion succeeded |
Date: |
Sat, 10 Jun 2023 05:12:18 -0400 (EDT) |
branch: emacs-29
commit 0d8b69e0ad37fe2d801e16a0ccafd8759dd33d02
Author: Morgan Smith <Morgan.J.Smith@outlook.com>
Commit: Eli Zaretskii <eliz@gnu.org>
Don't ding when completion succeeded
* lisp/minibuffer.el (minibuffer-completion-help): Ensure 'ding'
is not called on a successful completion. Ensure 'ding' is not
called on a failure if 'completion-fail-discreetly' is set.
Also change "No completions" to "No match" as that is what is
used elsewhere. (Bug#63913)
---
lisp/minibuffer.el | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index a873e5f9747..44226449af2 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -2388,9 +2388,11 @@ These include:
;; If there are no completions, or if the current input is already
;; the sole completion, then hide (previous&stale) completions.
(minibuffer-hide-completions)
- (ding)
- (completion--message
- (if completions "Sole completion" "No completions")))
+ (if completions
+ (completion--message "Sole completion")
+ (unless completion-fail-discreetly
+ (ding)
+ (completion--message "No match"))))
(let* ((last (last completions))
(base-size (or (cdr last) 0))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- emacs-29 0d8b69e0ad3: Don't ding when completion succeeded,
Eli Zaretskii <=