[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master e067f2763fd 2/2: Rename a recently-added variable (bug#56197)
From: |
Eli Zaretskii |
Subject: |
master e067f2763fd 2/2: Rename a recently-added variable (bug#56197) |
Date: |
Sat, 1 Feb 2025 05:23:51 -0500 (EST) |
branch: master
commit e067f2763fd52b78342b5c759205032227e82ebe
Author: Eli Zaretskii <eliz@gnu.org>
Commit: Eli Zaretskii <eliz@gnu.org>
Rename a recently-added variable (bug#56197)
* lisp/emacs-lisp/lisp-mode.el
(lisp-fill-paragraphs-as-doc-string): Renamed from
'lisp-fill-paragraph-as-displayed' and default value reversed.
(lisp-fill-paragraph): Adjust to the change.
* test/lisp/emacs-lisp/lisp-mode-tests.el
(lisp-fill-paragraph-as-displayed): Likewise.
---
lisp/emacs-lisp/lisp-mode.el | 13 +++++++------
test/lisp/emacs-lisp/lisp-mode-tests.el | 2 +-
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
index 3b1d34bf7cd..1349a5212ed 100644
--- a/lisp/emacs-lisp/lisp-mode.el
+++ b/lisp/emacs-lisp/lisp-mode.el
@@ -1431,16 +1431,17 @@ Any non-integer value means do not use a different
value of
:group 'lisp
:version "30.1")
-(defvar lisp-fill-paragraph-as-displayed nil
- "Modify the behavior of `lisp-fill-paragraph'.
+(defvar lisp-fill-paragraphs-as-doc-string t
+ "Whether `lisp-fill-paragraph' should fill strings as ELisp doc strings.
The default behavior of `lisp-fill-paragraph' is tuned for filling Emacs
Lisp doc strings, with their special treatment for the first line.
-Particularly, strings are filled in a narrowed context to avoid filling
+Specifically, strings are filled in a narrowed context to avoid filling
surrounding code, which means any leading indent is disregarded, which
can cause the filled string to extend passed the configured
`fill-column' variable value. If you would rather fill the string in
-its original context and ensure the `fill-column' value is more strictly
-respected, set this variable to true. Doing so makes
+its original context, disregarding the special conventions of ELisp doc
+strings, and want to ensure the `fill-column' value is more strictly
+respected, set this variable to nil. Doing so makes
`lisp-fill-paragraph' behave as it used to in Emacs 27 and prior
versions.")
@@ -1506,7 +1507,7 @@ and initial semicolons."
;; code.
(if (not string-start)
(lisp--fill-line-simple)
- (unless lisp-fill-paragraph-as-displayed
+ (when lisp-fill-paragraphs-as-doc-string
;; If we're in a string, then narrow (roughly) to that
;; string before filling. This avoids filling Lisp
;; statements that follow the string.
diff --git a/test/lisp/emacs-lisp/lisp-mode-tests.el
b/test/lisp/emacs-lisp/lisp-mode-tests.el
index 96e37114276..676d4f2ab4a 100644
--- a/test/lisp/emacs-lisp/lisp-mode-tests.el
+++ b/test/lisp/emacs-lisp/lisp-mode-tests.el
@@ -333,7 +333,7 @@ Here is some more text.\"
(ert-deftest lisp-fill-paragraph-as-displayed ()
"Test bug#56197 -- more specifically, validate that a leading indentation
for a string is preserved in the filled string."
- (let ((lisp-fill-paragraph-as-displayed t) ;variable under test
+ (let ((lisp-fill-paragraphs-as-doc-string nil) ;variable under test
;; The following is a contrived example that demonstrates the
;; fill-column problem when the string to fill is indented.
(source "\