emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/posframe dd97448 07/13: Remove face-remap feature.


From: Feng Shu
Subject: [elpa] externals/posframe dd97448 07/13: Remove face-remap feature.
Date: Sat, 8 Jun 2019 19:42:27 -0400 (EDT)

branch: externals/posframe
commit dd97448300cbe5adaef96bfbf542dbb88ecf82e6
Author: Feng Shu <address@hidden>
Commit: Feng Shu <address@hidden>

    Remove face-remap feature.
    
    Let face-remapping-alist buffer-local is not a good idea, more info:
    
    https://lists.gnu.org/archive/html/emacs-devel/2019-03/msg00195.html
---
 posframe.el | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/posframe.el b/posframe.el
index 01ce127..7f68a5c 100644
--- a/posframe.el
+++ b/posframe.el
@@ -194,8 +194,7 @@ frame.")
                                      keep-ratio
                                      override-parameters
                                      respect-header-line
-                                     respect-mode-line
-                                     face-remap)
+                                     respect-mode-line)
   "Create a child-frame for posframe.
 This posframe's buffer is POSFRAME-BUFFER."
   (let ((left-fringe (or left-fringe 0))
@@ -213,8 +212,7 @@ This posframe's buffer is POSFRAME-BUFFER."
                     keep-ratio
                     override-parameters
                     respect-header-line
-                    respect-mode-line
-                    face-remap)))
+                    respect-mode-line)))
     (with-current-buffer posframe-buffer
       ;; Many variables take effect after call `set-window-buffer'
       (setq-local display-line-numbers nil)
@@ -228,7 +226,6 @@ This posframe's buffer is POSFRAME-BUFFER."
       (setq-local cursor-type nil)
       (setq-local cursor-in-non-selected-windows nil)
       (setq-local show-trailing-whitespace nil)
-      (setq-local face-remapping-alist face-remap)
       (unless respect-mode-line
         (setq-local mode-line-format nil))
       (unless respect-header-line
@@ -315,7 +312,6 @@ This posframe's buffer is POSFRAME-BUFFER."
                          background-color
                          respect-header-line
                          respect-mode-line
-                         face-remap
                          initialize
                          no-properties
                          keep-ratio
@@ -404,11 +400,6 @@ By default, posframe will force hide header-line and 
mode-line
 If user want to show header-line or mode-line in posframe,
 set RESPECT-HEADER-LINE or RESPECT-MODE-LINE to t.
 
-If user want to let posframe use different faces from other frame.
-user can set FACE-REMAP, more setting details can be found:
-
-  C-h v face-remapping-alist
-
 INITIALIZE is a function with no argument, it will run when
 posframe buffer is first selected with `with-current-buffer'
 in posframe-show, and only run once for speed reason, If INITIALIZE
@@ -475,7 +466,6 @@ you can use `posframe-delete-all' to delete all posframes."
              :keep-ratio keep-ratio
              :respect-header-line respect-header-line
              :respect-mode-line respect-mode-line
-             :face-remap face-remap
              :override-parameters override-parameters))
 
       ;; Insert string to posframe-buffer.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]