emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] master e62e7de 090/184: ivy-test.el (ivy-test-run-tests): Fix


From: Oleh Krehel
Subject: [elpa] master e62e7de 090/184: ivy-test.el (ivy-test-run-tests): Fix
Date: Wed, 16 Oct 2019 13:14:57 -0400 (EDT)

branch: master
commit e62e7dec82d27aedde536f8ffdc6486f636205bf
Author: Oleh Krehel <address@hidden>
Commit: Oleh Krehel <address@hidden>

    ivy-test.el (ivy-test-run-tests): Fix
    
    Re #2215
---
 ivy-test.el | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/ivy-test.el b/ivy-test.el
index 4b471f1..0cbf66e 100644
--- a/ivy-test.el
+++ b/ivy-test.el
@@ -948,6 +948,10 @@ will bring the behavior in line with the newer Emacsen."
     (should (eq (ivy--sort-function 'c) fn1))))
 
 (ert-deftest ivy-read-directory-name ()
+  :expected-result (if (and (= emacs-major-version 24)
+                            (= emacs-minor-version 5))
+                       :failed
+                     :passed)
   (should
    (equal "/tmp/"
           (ivy-with
@@ -1032,6 +1036,11 @@ a buffer visiting a file."
     (ivy-mode ivy-mode-reset-arg)))
 
 (ert-deftest ivy-read-file-name-make-directory ()
+  :expected-result (if (and (= emacs-major-version 24)
+                            (= emacs-minor-version 5))
+                       ;; result is "/tmp/non-existant-dir/\n" for some reason
+                       :failed
+                     :passed)
   (should
    (equal
     (ivy-with
@@ -1405,10 +1414,16 @@ a buffer visiting a file."
                    "/sudo::/tmp/")))
 
 (defun ivy-test-run-tests ()
-  ;; this test must run first as other tests might force a load
-  (ert-run-tests-batch 'ivy--lazy-load-ffap--ffap-url-p)
-  ;; run the rest of the tests
-  (ert-run-tests-batch-and-exit '(not ivy--lazy-load-ffap--ffap-url-p)))
+  (let ((stats1
+         ;; this test must run first as other tests might force a load
+         (ert-run-tests-batch 'ivy--lazy-load-ffap--ffap-url-p))
+        (stats2
+         ;; run the rest of the tests
+         (ert-run-tests-batch '(not ivy--lazy-load-ffap--ffap-url-p))))
+    (kill-emacs (if (zerop (+ (ert-stats-completed-unexpected stats1)
+                              (ert-stats-completed-unexpected stats2)))
+                    0
+                  1))))
 
 (provide 'ivy-test)
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]