emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/eglot ce983d1 47/69: Revert "Treat null/nil server capa


From: João Távora
Subject: [elpa] externals/eglot ce983d1 47/69: Revert "Treat null/nil server capabilities as false"
Date: Sun, 20 Oct 2019 08:21:50 -0400 (EDT)

branch: externals/eglot
commit ce983d1fc3d777beaba1c7e472bf819511605bb0
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>

    Revert "Treat null/nil server capabilities as false"
    
    This reverts commit 6d87de16c5f86c5479db5e6705f0fb93fe727d3e.
    
    A capability of "null" is downright invalid, and must NOT be mistaken
    for a value of "{}" (which indicates the presence of the capability)
    or "False" (which indicates its asence).  See
    
https://github.com/microsoft/language-server-protocol/issues/830#issuecomment-537849292
    for a clarification from the LSP maintainer.
---
 eglot.el | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/eglot.el b/eglot.el
index ef7f8f0..d1a1a3d 100644
--- a/eglot.el
+++ b/eglot.el
@@ -1113,9 +1113,6 @@ under cursor."
              for probe = (plist-member caps feat)
              if (not probe) do (cl-return nil)
              if (eq (cadr probe) :json-false) do (cl-return nil)
-             ;; If the server specifies null as the value of the capability, it
-             ;; makes sense to treat it like false.
-             if (null (cadr probe)) do (cl-return nil)
              if (not (listp (cadr probe))) do (cl-return (if more nil (cadr 
probe)))
              finally (cl-return (or (cadr probe) t)))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]