[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/javaimp 4fa5d2a 12/32: * packages/javaimp/javaimp.el: F
From: |
Stefan Monnier |
Subject: |
[elpa] externals/javaimp 4fa5d2a 12/32: * packages/javaimp/javaimp.el: Fix some compiler warnings |
Date: |
Tue, 1 Dec 2020 10:08:28 -0500 (EST) |
branch: externals/javaimp
commit 4fa5d2a713d91d1541665dadf6f733f34657707b
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>
* packages/javaimp/javaimp.el: Fix some compiler warnings
---
javaimp.el | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/javaimp.el b/javaimp.el
index 68079c0..ca1a710 100644
--- a/javaimp.el
+++ b/javaimp.el
@@ -1,6 +1,6 @@
;;; javaimp.el --- Add and reorder Java import statements in Maven projects
-*- lexical-binding: t; -*-
-;; Copyright (C) 2014 Free Software Foundation, Inc.
+;; Copyright (C) 2014, 2015 Free Software Foundation, Inc.
;; Author: Filipp Gunbin <fgunbin@fastmail.fm>
;; Maintainer: Filipp Gunbin <fgunbin@fastmail.fm>
@@ -90,6 +90,9 @@
;;; User options
+(defgroup javaimp ()
+ "Add and reorder Java import statements in Maven projects.")
+
(defcustom javaimp-import-group-alist '(("\\`javax?\\." . 10))
"Specifies how to group classes and how to order resulting groups in the
imports list. Each element should be of the form `(CLASSNAME-REGEXP
@@ -191,6 +194,8 @@ class name. The order of classes which were not matched is
defined by
;; An artifact is represented as a list: (GROUP-ID ARTIFACT-ID VERSION).
+;; FIXME: use cl-defstruct!
+
(defun javaimp-make-artifact (group-id artifact-id version)
(list group-id artifact-id version))
@@ -201,13 +206,13 @@ class name. The order of classes which were not matched
is defined by
(cadr artifact))
(defun javaimp-artifact-version (artifact)
- (caddr artifact))
+ (nth 2 artifact))
(defun javaimp-artifact-to-string (artifact)
(format "%s:%s:%s"
(javaimp-artifact-artifact-id artifact)
(javaimp-artifact-group-id artifact)
- (javaimp-artifact-version (artifact))))
+ (javaimp-artifact-version artifact))) ;FIXME: `artifact' is not a
function!
(defun javaimp-parse-artifact (artifact)
(apply #'javaimp-make-artifact (split-string artifact ":")))
@@ -271,7 +276,7 @@ with POM"
(javaimp-call-mvn
pom "help:effective-pom"
(lambda ()
- (let (xml-start-pos xml-end-pos start-tag)
+ (let (xml-start-pos xml-end-pos)
;; find where we should start parsing XML
(goto-char (point-min))
(re-search-forward "<\\?xml\\|<projects?>")
- [elpa] externals/javaimp c2bb0bc 01/32: * javaimp: New package., (continued)
- [elpa] externals/javaimp c2bb0bc 01/32: * javaimp: New package., Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp 60a7312 02/32: javaimp: converted to lexical binding, doc fixes, minor code fixes, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp c38cd53 03/32: javaimp: fixed lexical-binding var placement, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp 170e1cd 05/32: javaimp: version 0.5, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp 07e5c0f 04/32: javaimp: fix for cases when maven doesn't add xml declaration, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp f8681a5 07/32: packages/javaimp/javaimp.el: added check for changes in parent pom, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp 177572a 08/32: packages/javaimp/javaimp.el: parent pom check fix, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp 59f2e14 11/32: packages/javaimp/javaimp.el: use line-beginning-position instead of forward-line, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp d65f827 09/32: minor fixes, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp 4be004d 10/32: packages/javaimp/javaimp.el: replace kill-line with delete-region, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp 4fa5d2a 12/32: * packages/javaimp/javaimp.el: Fix some compiler warnings,
Stefan Monnier <=
- [elpa] externals/javaimp 32304ae 14/32: javaimp.el: Fix Maven output start regexp., Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp b5158b9 15/32: * packages/javaimp/javaimp.el: Update javaimp to v. 0.6., Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp 069aa0c 06/32: javaimp: doc fixes, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp d1507ca 13/32: packages/javaimp/javaimp.el: Support additional source directories., Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp c59e1f7 22/32: packages/javaimp: Fix comparison of module load ts with parent files., Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp eb08936 23/32: Fix some quoting problems in doc strings, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp ed26a43 24/32: * javaimp.el: Add missing license, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp 88f1376 27/32: [javaimp] Bump version to 0.6.1, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp 084153c 29/32: packages/javaimp/javaimp.el: Add News section, bump version to 0.7, Stefan Monnier, 2020/12/01
- [elpa] externals/javaimp 3c95c22 32/32: * .gitignore: New file, Stefan Monnier, 2020/12/01