[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/el-search e2f56c7 109/332: Simplify nested backquotes
From: |
Stefan Monnier |
Subject: |
[elpa] externals/el-search e2f56c7 109/332: Simplify nested backquotes |
Date: |
Tue, 1 Dec 2020 15:48:23 -0500 (EST) |
branch: externals/el-search
commit e2f56c75e5964db1ae68d69eb8b8114f1dd1c676
Author: Michael Heerdegen <michael_heerdegen@web.de>
Commit: Michael Heerdegen <michael_heerdegen@web.de>
Simplify nested backquotes
---
el-search.el | 24 +++++-------------------
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/el-search.el b/el-search.el
index b5c25ad..39c8026 100644
--- a/el-search.el
+++ b/el-search.el
@@ -665,19 +665,6 @@ MESSAGE are used to construct the error message."
;;;; Additional pattern type definitions
-;; Hint: we sometimes need to create (pcase) backquote forms with
-;; backquote. I do this like in this example:
-;;
-;; (let ((y 2))
-;; `(,'\` ((,'\, x) ,y)))
-;; ==> `(,x 2)
-;;
-;; Note that the backslashes are mandatory, else the reader macros are
-;; interpreted as composition of the respective operations, like in
-;;
-;; `(', (+ 1 2)) ==> ('3)
-
-
(defun el-search--split (matcher1 matcher2 list)
"Helper for the append pattern type.
@@ -727,8 +714,7 @@ matches the list (1 2 3 4 5 6 7 8 9) and binds `x' to (4 5
6)."
(app ,(apply-partially #'el-search--split
(el-search--matcher pattern)
(el-search--matcher (car more-patterns)))
- (,'\` ((,'\, ,pattern)
- (,'\, ,(car more-patterns)))))))
+ `(,,pattern ,,(car more-patterns)))))
(t `(append ,pattern (append ,@more-patterns)))))))
(defun el-search--stringish-p (thing)
@@ -775,7 +761,7 @@ of any kind matched by all PATTERNs are also matched.
((null (cdr patterns))
(let ((pattern (car patterns)))
`(app ,(apply-partially #'el-search--contains-p (el-search--matcher
pattern))
- (,'\` (t (,'\, ,pattern))))))
+ `(t ,,pattern))))
(t `(and ,@(mapcar (lambda (pattern) `(contains ,pattern)) patterns)))))
(el-search-defpattern not (pattern)
@@ -842,8 +828,8 @@ matches any of these expressions:
(defun el-search--transform-nontrivial-lpat (expr)
(cond
((symbolp expr) `(or (symbol ,(symbol-name expr))
- (,'\` (,'quote (,'\, (symbol ,(symbol-name expr)))))
- (,'\` (,'function (,'\, (symbol ,(symbol-name
expr)))))))
+ `',(symbol ,(symbol-name expr))
+ `#',(symbol ,(symbol-name expr))))
((stringp expr) `(string ,expr))
(t expr)))
@@ -890,7 +876,7 @@ could use this pattern:
('_ '`(,_))
('_? '(or '() `(,_))) ;FIXME: useful - document? or should
we provide a (? PAT)
;thing?
- (_ `(,'\` ((,'\, ,(el-search--transform-nontrivial-lpat
elt)))))))
+ (_ ``(,,(el-search--transform-nontrivial-lpat elt)))))
lpats)
,@(if match-end '() '(_)))))
- [elpa] externals/el-search 4325b91 080/332: Rename two functions, (continued)
- [elpa] externals/el-search 4325b91 080/332: Rename two functions, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search ba17f50 086/332: Give el-search--s a more meaningful name, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search d25f4d8 082/332: Address compiler warnings, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 2358b72 088/332: Small fix in el-search--setup-minibuffer, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 75b5849 083/332: Clarify the operation scope of replacing, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search e1797d3 087/332: Use `pp-to-string' to print replacement expression, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search ef5faf2 095/332: Improve history handling, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 4d6b361 097/332: el-search--ensure-sexp-start: don't assume point-min==1, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search e38bea8 106/332: Add calling convention to el-search-defpattern's docstring, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search e54336d 104/332: Fix el-search-query-replace reindent wrongly in narrowed buffer, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search e2f56c7 109/332: Simplify nested backquotes,
Stefan Monnier <=
- [elpa] externals/el-search e7dda1b 118/332: Call el-search--wrap-pattern at better places, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 922281a 112/332: Fix replacement verification for splicing mode, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 6de72a5 121/332: `change', `changed': make "HEAD" as default explicit, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 7fe5fb7 126/332: Some details, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 2a0773f 134/332: Use jka-compr-load-suffixes instead of hardcoded suffixes, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 644b04d 139/332: el-search: bump version to 1.2.2, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search b500266 151/332: Tweak el-search--pp-to-string, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 79095f6 143/332: Improve summary message of `el-search-overview', Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 3772a97 133/332: Add a helpful comment; bump version to 1.2.1, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 0808109 161/332: Fix el-search--change-p for atoms, Stefan Monnier, 2020/12/01