[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/el-search bd67d58 239/332: [el-search] Raise user-error
From: |
Stefan Monnier |
Subject: |
[elpa] externals/el-search bd67d58 239/332: [el-search] Raise user-error when replacement contains gensyms |
Date: |
Tue, 1 Dec 2020 15:48:54 -0500 (EST) |
branch: externals/el-search
commit bd67d586bd782ece0fec1c882e912f0279558996
Author: Michael Heerdegen <michael_heerdegen@web.de>
Commit: Michael Heerdegen <michael_heerdegen@web.de>
[el-search] Raise user-error when replacement contains gensyms
* el-search/el-search.el (el-search--format-replacement): Raise a
`user-error' when replacement contains uninterned symbols.
Also improve the comment about this issue in the file header.
---
el-search.el | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/el-search.el b/el-search.el
index 0f2c77b..8f032a5 100644
--- a/el-search.el
+++ b/el-search.el
@@ -369,11 +369,11 @@
;;
;; the comment will be lost.
;;
-;; - Something like '(1 #1#) is unmatchable (because it is
-;; un`read'able without context). For a similar reason it is
-;; currently not possible to allow a replacement to contain
-;; uninterned symbols or repeated/circular parts.
+;; - Something like (1 #1#) is unmatchable (because it is un`read'able
+;; without context).
;;
+;; - In el-search-query-replace, replacements are not allowed to
+;; contain uninterned symbols.
;;
;;
;; BUGS
@@ -3245,6 +3245,12 @@ reindent."
(goto-char 1)
(forward-sexp (if splice (length replacement) 1))
(let ((result (buffer-substring 1 (point))))
+ (when (cl-some
+ (lambda (thing) (and (symbolp thing) thing (not
(intern-soft thing))))
+ (el-search--flatten-tree replacement))
+ ;; el-search can't handle #N read syntax; we print the
replacement
+ ;; with print-circle -> nil
+ (user-error "The replacement is not allowed to contain
uninterned symbols"))
(if (condition-case nil
(equal replacement (el-search-read (if splice (format
"(%s)" result) result)))
((debug error) nil))
- [elpa] externals/el-search 6b01504 210/332: Add command `el-search-ibuffer-marked-buffers', (continued)
- [elpa] externals/el-search 6b01504 210/332: Add command `el-search-ibuffer-marked-buffers', Stefan Monnier, 2020/12/01
- [elpa] externals/el-search d869368 211/332: Implement `cl-print-object' for el-search-objects, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 6251577 213/332: * el-search/el-search.el: Add `el-search-edit-search-description', Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 48103e3 221/332: * el-search/el-search.el: Fix handling of void replacements, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 7c099aa 225/332: Small improvements to el-search--search-and-replace-pattern, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search da7857b 227/332: * el-search/el-search.el: Add `el-search-looking-at', Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 9f400b4 234/332: * el-search/el-search.el: Fix infloop in el-search--flatten-tree, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 3bb5b76 236/332: * el-search/el-search.el: Prefer adverb "backward" in names and text, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 41e0251 224/332: * el-search/el-search.el: Bump version to 1.6; some minor tweaks, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search c4eeae5 223/332: * el-search/el-search.el: Fix single buffer query-replace, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search bd67d58 239/332: [el-search] Raise user-error when replacement contains gensyms,
Stefan Monnier <=
- [elpa] externals/el-search 96b7423 245/332: [el-search] Special case 'el-search-make-matcher' for '_', Stefan Monnier, 2020/12/01
- [elpa] externals/el-search eef5de0 243/332: [el-search] Save two 'eval' calls, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 427afa8 253/332: [el-search] Bump version to 1.7.1, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 0907a21 248/332: [el-search] Bump version to 1.7, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 1bc9c89 252/332: [el-search] Improve 'el-search-display-match-count', Stefan Monnier, 2020/12/01
- [elpa] externals/el-search ba806ce 251/332: [el-search] Enforce defun start for heuristic matching, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search ab5bcd8 266/332: [el-search] Follow-up to "Fix nested match issues in *El Occur*", Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 2c2930b 256/332: * el-search/el-search.el: Again tweak commentary in header, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search 5e97386 255/332: [el-search] Improve match faces, Stefan Monnier, 2020/12/01
- [elpa] externals/el-search fdb5656 270/332: [el-search] Make y move forward after replacing, Stefan Monnier, 2020/12/01