[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] elpa-admin 6ba7e63 077/357: Try to preserve timestamps. Fix Chang
From: |
Stefan Monnier |
Subject: |
[elpa] elpa-admin 6ba7e63 077/357: Try to preserve timestamps. Fix ChangeLog generation. |
Date: |
Thu, 10 Dec 2020 18:06:18 -0500 (EST) |
branch: elpa-admin
commit 6ba7e63c4f7f9b080c7bddc9a1d72001f2184273
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>
Try to preserve timestamps. Fix ChangeLog generation.
* admin/update-archive.sh: Don't change timestamp on packages that have the
same md5.
* admin/archive-contents.el (batch-prepare-packages): New function.
(archive--simple-package-p): Ignore ChangeLog as well. Signal errors if the
file does not have the expected structure.
(archive--process-simple-package): Add the ChangeLog's content.
(archive--make-changelog): Only modify the file if the content changes.
(archive--process-multi-file-package): Don't make the ChangeLog here, since
we
may not even have the Bzr metadata at hand any more.
* Makefile (archive-tmp): Preserve symlinks.
(process-archive): Call new batch-prepare-packages.
* .bzrignore: Add Changelog and .changelog-witness.
---
admin/archive-contents.el | 108 ++++++++++++++++++++++++++++++++++++----------
1 file changed, 86 insertions(+), 22 deletions(-)
diff --git a/admin/archive-contents.el b/admin/archive-contents.el
index f2b6830..152a56a 100644
--- a/admin/archive-contents.el
+++ b/admin/archive-contents.el
@@ -76,7 +76,7 @@ Delete backup files also."
;; Test whether this is a simple or multi-file package.
(setq simple-p (archive--simple-package-p dir pkg))
(push (if simple-p
- (apply 'archive--process-simple-package
+ (apply #'archive--process-simple-package
dir pkg simple-p)
(archive--process-multi-file-package dir pkg))
packages)))
@@ -86,6 +86,41 @@ Delete backup files also."
(pp (nreverse packages) (current-buffer))
(write-region nil nil "archive-contents"))))
+(defun batch-prepare-packages ()
+ "Prepare the `packages' directory inside the Bzr checkout.
+Expects to be called from within the `packages' directory.
+\"Prepare\" here is for subsequent construction of the packages and archive,
+so it is meant to refresh any generated files we may need.
+Currently only refreshes the ChangeLog files."
+ (let* ((wit ".changelog-witness")
+ (prevno (or (with-temp-buffer
+ (ignore-errors (insert-file-contents wit))
+ (when (looking-at "[1-9][0-9]*\\'")
+ (string-to-number (match-string 0))))
+ 1))
+ (new-revno
+ (or (with-temp-buffer
+ (call-process "bzr" nil '(t) nil "revno")
+ (goto-char (point-min))
+ (when (looking-at "[1-9][0-9]*$")
+ (string-to-number (match-string 0))))
+ (error "bzr revno did not return a number as expected")))
+ (pkgs '()))
+ (unless (= prevno new-revno)
+ (with-temp-buffer
+ (unless (zerop (call-process "bzr" nil '(t) nil "log" "-v"
+ (format "-r%d.." (1+ prevno))))
+ (error "Error signaled by bzr log -v -r%d.." (1+ prevno)))
+ (goto-char (point-min))
+ (while (re-search-forward "^ packages/\\([-[:alnum:]]+\\)/" nil t)
+ (cl-pushnew (match-string 1) pkgs :test #'equal))))
+ (dolist (pkg pkgs)
+ (condition-case v
+ (if (file-directory-p pkg)
+ (archive--make-changelog pkg))
+ (error (message "%s" (cadr v)))))
+ (write-region (number-to-string new-revno) nil wit nil 'quiet)))
+
(defun archive--simple-package-p (dir pkg)
"Test whether DIR contains a simple package named PKG.
If so, return a list (VERSION DESCRIPTION REQ COMMENTARY), where
@@ -100,27 +135,32 @@ Otherwise, return nil."
(dolist (file (prog1 files (setq files ())))
(unless (string-match "\\.elc\\'" file)
(push file files)))
- (when (and (or (not (file-exists-p pkg-file))
- (= (length files) 2))
- (file-exists-p mainfile))
+ (setq files (delete (concat pkg "-pkg.el") files))
+ (setq files (delete (concat pkg "-autoloads.el") files))
+ (setq files (delete "ChangeLog" files))
+ (cond
+ ((and (or (not (file-exists-p pkg-file))
+ (= (length files) 1))
+ (file-exists-p mainfile))
(with-temp-buffer
(insert-file-contents mainfile)
(goto-char (point-min))
- (and (looking-at ";;;.*---[ \t]*\\(.*?\\)[ \t]*\\(-\\*-.*-\\*-[
\t]*\\)?$")
- (progn
- (setq description (match-string 1))
- (setq version
- (or (archive--strip-rcs-id (lm-header "package-version"))
- (archive--strip-rcs-id (lm-header "version"))
- "0.0")))
- (progn
- ;; Grab the other fields, which are not mandatory.
- (let ((requires-str (lm-header "package-requires")))
- (if requires-str
- (setq req (mapcar 'archive--convert-require
- (car (read-from-string requires-str))))))
- (setq commentary (lm-commentary))
- (list version description req commentary)))))))
+ (if (not (looking-at ";;;.*---[ \t]*\\(.*?\\)[ \t]*\\(-\\*-.*-\\*-[
\t]*\\)?$"))
+ (error "Can't parse first line of %s" mainfile)
+ (setq description (match-string 1))
+ (setq version
+ (or (archive--strip-rcs-id (lm-header "package-version"))
+ (archive--strip-rcs-id (lm-header "version"))
+ (error "Missing `version' header")))
+ ;; Grab the other fields, which are not mandatory.
+ (let ((requires-str (lm-header "package-requires")))
+ (if requires-str
+ (setq req (mapcar 'archive--convert-require
+ (car (read-from-string requires-str))))))
+ (setq commentary (lm-commentary))
+ (list version description req commentary))))
+ ((not (file-exists-p pkg-file))
+ (error "Can find single file nor package desc file in %s" dir)))))
(defun archive--process-simple-package (dir pkg vers desc req commentary)
"Deploy the contents of DIR into the archive as a simple package.
@@ -147,14 +187,39 @@ package commentary to PKG-readme.txt. Return the
descriptor."
;; Write DIR/foo.el to foo-VERS.el and delete DIR
(rename-file (expand-file-name (concat pkg ".el") dir)
(concat pkg "-" vers ".el"))
+ ;; Add the content of the ChangeLog.
+ (let ((cl (expand-file-name "ChangeLog" dir)))
+ (with-current-buffer (find-file-noselect (concat pkg "-" vers ".el"))
+ (goto-char (point-max))
+ (re-search-backward "^;;;.*ends here")
+ (re-search-backward "^(provide")
+ (skip-chars-backward " \t\n")
+ (insert "\n")
+ (let ((start (point)))
+ (insert-file-contents cl)
+ (unless (bolp) (insert "\n"))
+ (comment-region start (point)))
+ (save-buffer)
+ (kill-buffer)))
(delete-directory dir t)
(cons (intern pkg) (vector (version-to-list vers) req desc 'single)))
(defun archive--make-changelog (dir)
"Export Bzr log info of DIR into a ChangeLog file."
+ (message "Refreshing ChangeLog in %S" dir)
(let ((default-directory (file-name-as-directory (expand-file-name dir))))
- (call-process "bzr" nil '(:file "ChangeLog") nil
- "log" "--gnu-changelog" ".")))
+ (with-temp-buffer
+ (set-buffer-multibyte nil)
+ (let ((coding-system-for-read 'binary)
+ (coding-system-for-write 'binary))
+ (if (file-readable-p "ChangeLog") (insert-file-contents "ChangeLog"))
+ (let ((old-md5 (md5 (current-buffer))))
+ (erase-buffer)
+ (call-process "bzr" nil (current-buffer) nil
+ "log" "--gnu-changelog" ".")
+ (if (equal old-md5 (md5 (current-buffer)))
+ (message "ChangeLog's md5 unchanged for %S" dir)
+ (write-region (point-min) (point-max) "ChangeLog" nil 'quiet)))))))
(defun archive--process-multi-file-package (dir pkg)
"Deploy the contents of DIR into the archive as a multi-file package.
@@ -164,7 +229,6 @@ PKG-readme.txt. Return the descriptor."
(vers (nth 2 exp))
(req (mapcar 'archive--convert-require (nth 4 exp)))
(readme (expand-file-name "README" dir)))
- (archive--make-changelog dir)
(unless (equal (nth 1 exp) pkg)
(error (format "Package name %s doesn't match file name %s"
(nth 1 exp) pkg)))
- [elpa] elpa-admin 842d54c 056/357: * admin/archive-contents.el (batch-make-site-dir, archive--write-pkg-file): New functions., (continued)
- [elpa] elpa-admin 842d54c 056/357: * admin/archive-contents.el (batch-make-site-dir, archive--write-pkg-file): New functions., Stefan Monnier, 2020/12/10
- [elpa] elpa-admin becd7be 063/357: * archive-contents.el (archive--make-changelog): New fun., Stefan Monnier, 2020/12/10
- [elpa] elpa-admin 33a5782 042/357: Ensure case-fold-search=t in the example email detect function, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin cff4ab8 045/357: Add a note for programmers about wcheck-marked-text-at, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin 3afe3ac 060/357: Use org-mode markup in README and rename it to README.org, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin dc8ca2b 072/357: Note availability of Melpa packages, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin e5ad0fa 044/357: Rephrase examples, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin 518362a 073/357: Merge pull request #13 from dgutov/master, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin c51af29 058/357: Reorganize repository layout, allowing site installation., Stefan Monnier, 2020/12/10
- [elpa] elpa-admin e148a06 052/357: Put quotes `...' around the example function add-word-to-dictionary, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin 6ba7e63 077/357: Try to preserve timestamps. Fix ChangeLog generation.,
Stefan Monnier <=
- [elpa] elpa-admin cd01c51 080/357: Remove the angle brackets, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin febff3e 079/357: Make README more up-to-date, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin 73304d8 097/357: Fix up deployment script, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin 1d4d089 094/357: Mark merge point of ack-el., Stefan Monnier, 2020/12/10
- [elpa] elpa-admin de56f9a 095/357: Mark merge point of company., Stefan Monnier, 2020/12/10
- [elpa] elpa-admin b0862f3 103/357: * README: Update with corrected information., Stefan Monnier, 2020/12/10
- [elpa] elpa-admin d406160 122/357: Merge the two README. Update copyright_exceptions., Stefan Monnier, 2020/12/10
- [elpa] elpa-admin e52215f 124/357: first commit, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin c8efad2 096/357: Fix up copyrights and the checking code, Stefan Monnier, 2020/12/10
- [elpa] elpa-admin a0b6599 127/357: Subject: Fix up quoting of keywords. Remove leftover support for *-pkg.el., Stefan Monnier, 2020/12/10