emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/trie f676ea0 091/111: Fix off-by-1 bug in Lewenstein di


From: Stefan Monnier
Subject: [elpa] externals/trie f676ea0 091/111: Fix off-by-1 bug in Lewenstein distance queries.
Date: Mon, 14 Dec 2020 11:35:27 -0500 (EST)

branch: externals/trie
commit f676ea0b2b8f14d2a1c37ec29da52f6cf6188959
Author: Toby S. Cubitt <toby-predictive@dr-qubit.org>
Commit: Toby S. Cubitt <toby-predictive@dr-qubit.org>

    Fix off-by-1 bug in Lewenstein distance queries.
---
 trie.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/trie.el b/trie.el
index abdea89..6d4befc 100644
--- a/trie.el
+++ b/trie.el
@@ -2209,7 +2209,7 @@ of the default key-dist-data list."
               row string (trie--node-split node) equalfun)
          seq (trie--seq-append seq (trie--node-split node)))
 
-    ;; as long as some row entry is < DISTANCE, recursively search below NODE
+    ;; as long as some row entry is <= DISTANCE, recursively search below NODE
     (when (<= (apply #'min (append row nil)) distance)
       (funcall mapfun
               (lambda (n)
@@ -2311,7 +2311,7 @@ STRING."
                           row string (trie--node-split node) equalfun))
            ;; push children of non-data nodes whose SEQ is less than DISTANCE
            ;; onto stack
-           (when (< (apply #'min (append row nil)) distance)
+           (when (<= (apply #'min (append row nil)) distance)
              (push
               (list (trie--seq-append seq (trie--node-split node))
                     (funcall stack-createfun
@@ -2493,7 +2493,7 @@ of the default key-dist-data list."
            pfxlen (length seq)))
 
     ;; as long as some row entry is < DISTANCE, recursively search below NODE
-    (if (< (apply #'min (append row nil)) distance)
+    (if (<= (apply #'min (append row nil)) distance)
        (funcall mapfun
                 (lambda (n)
                   (trie--do-fuzzy-complete
@@ -2634,9 +2634,9 @@ give meaningful results; use `trie-complete-stack' 
instead.)"
                     prefix t row pfxcost pfxlen)
               store))
 
-            ;; if some row entry for non-data node is < DISTANCE, push node
+            ;; if some row entry for non-data node is <= DISTANCE, push node
             ;; onto stack
-            ((< (apply #'min (append row nil)) distance)
+            ((<= (apply #'min (append row nil)) distance)
              (push
               (list seq
                     (funcall stack-createfun



reply via email to

[Prev in Thread] Current Thread [Next in Thread]