[elpa] externals/dict-tree 22d0e13 140/154: Sort completions by fuzzy dist before ngram length.

[Stefan Monnier]

branch: externals/dict-tree
commit 22d0e1326e839f1caae69ea142fd48a3bcf0c190
Author: Toby S. Cubitt <toby-predictive@dr-qubit.org>
Commit: Toby S. Cubitt <toby-predictive@dr-qubit.org>

    Sort completions by fuzzy dist before ngram length.
---
 dict-tree.el | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dict-tree.el b/dict-tree.el
index 415e24b..97d3e25 100644
--- a/dict-tree.el
+++ b/dict-tree.el
@@ -559,6 +559,12 @@ If START or END is negative, it counts from the end."
        (if (funcall cmpfun (car list2) (car list1))
            (push (pop list2) res)
          ;; if elements are equal, merge them for non-null COMBFUN
+         ;; !!!!!!!!!!!!!!!!!!!!!!!!!!! FIXME !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+         ;; Doesn't combine duplicate completions, combines things that
+         ;; happen to compare equal. Depending on CMPFUN, this could combine
+         ;; things that shouldn't be combined, or fail to combine things that
+         ;; should be.
+         ;; !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
          (if combfun
              (push (funcall combfun (pop list1) (pop list2))
                    res)