[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/auto-overlays 0936d26 39/93: Work around goto-line bug.
From: |
Stefan Monnier |
Subject: |
[elpa] externals/auto-overlays 0936d26 39/93: Work around goto-line bug. |
Date: |
Mon, 14 Dec 2020 13:00:33 -0500 (EST) |
branch: externals/auto-overlays
commit 0936d26693ee90765cde714c90def27a0bf2a540
Author: Toby Cubitt <toby-predictive@dr-qubit.org>
Commit: tsc25 <toby-predictive@dr-qubit.org>
Work around goto-line bug.
---
auto-overlays.el | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/auto-overlays.el b/auto-overlays.el
index b0f81a9..74b6904 100644
--- a/auto-overlays.el
+++ b/auto-overlays.el
@@ -34,6 +34,8 @@
;; * allow SAVE-FILE argument of `auto-overlay-start/stop' to specify a
;; location to save to
;; * made corresponding modifications to `auto-overlay-save/load-overlays'
+;; * work around `goto-line' bug to prevent mark being set and message being
+;; displayed by `auto-overlay-update'
;;
;; Version 0.9.1
;; * modified `completion-unload-definition/regexp' functions so that they
@@ -1184,7 +1186,17 @@ overlays were saved."
(unless start (setq start (line-number-at-pos)))
(save-excursion
(save-match-data
- (goto-line start)
+ ;; (goto-line start) without messing around with mark and messages
+ ;; Note: this is a bug in simple.el; there clearly can be a need for
+ ;; non-interactive calls to goto-line from Lisp code, and
+ ;; there's no warning about doing this. Yet goto-line *always*
+ ;; calls push-mark, which usually *shouldn't* be invoked by
+ ;; Lisp programs, as its docstring warns.
+ (goto-char 1)
+ (if (eq selective-display t)
+ (re-search-forward "[\n\C-m]" nil 'end (1- start))
+ (forward-line (1- start)))
+
(dotimes (i (if end (1+ (- end start)) 1))
;; check each enabled set of overlays, or just the specified set
- [elpa] externals/auto-overlays 033900e 90/93: Fix some quoting problems in doc strings, (continued)
- [elpa] externals/auto-overlays 033900e 90/93: Fix some quoting problems in doc strings, Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays db9036a 92/93: * packages/auto-overlays/: Activate lexical-binding., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays d66bab4 11/93: Fixed "self" regexp bugs in auto-overlay package., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 86c25df 14/93: Removed auto-overlay-functions variable, and implemented new regexp class interface, Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 622afa4 13/93: Another very similar bug fix to do with updating exclusive overlays., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 1db0b95 22/93: Various minor bug fixes, and changes to bring packages up to date, Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays ea600c4 27/93: Bug fixes to new update scheduling, and to loading overlays from file., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 734371d 43/93: Changed @ignore Texinfo command to flat overlay class., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 55e868d 30/93: auto-o-suicide also needs to remove old properties., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 5d5e09e 45/93: trivial whitespace changes, Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 0936d26 39/93: Work around goto-line bug.,
Stefan Monnier <=
- [elpa] externals/auto-overlays ff75a63 49/93: Bug-fix in auto-overlay-load-definition, Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 9e8ef72 36/93: Modified interface functions for defining auto-overlay regexps., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 5539596 56/93: Added missing (eval-when-compile (require 'cl))., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 0f02ef9 57/93: Fixed minor spelling errors in docstrings., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays f66e655 66/93: Update package headers for ELPA., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays cdf4e6a 70/93: Fix copyright assignment in auto-overlays manual., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 464d9ea 77/93: Refactor auto-overlay-regexps format and implement match hooks., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays 9fe619d 85/93: Fix bugs in auto-overlay saving/loading., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays e6e8a76 87/93: Fix auto-overlay package loading so requiring auto-overlayys pulls in all standard classes., Stefan Monnier, 2020/12/14
- [elpa] externals/auto-overlays c9abb18 15/93: Added "flat" regexp class to auto overlay package., Stefan Monnier, 2020/12/14