[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] externals/sly 748fd92 22/47: Do close streams in CLOSE-LISTENER
From: |
ELPA Syncer |
Subject: |
[nongnu] externals/sly 748fd92 22/47: Do close streams in CLOSE-LISTENER when closing SLYNK::LISTENER |
Date: |
Thu, 17 Dec 2020 18:57:17 -0500 (EST) |
branch: externals/sly
commit 748fd921ef220d25072ca646d4b125c4806c8025
Author: Luís Borges de Oliveira <lbo@siscog.pt>
Commit: João Távora <joaotavora@gmail.com>
Do close streams in CLOSE-LISTENER when closing SLYNK::LISTENER
Also, ignore errors when doing this in SLYNK::CLOSE-CONNECTION%.
This was inspired by SLIME commit
1761172817d2e1a8b48c216bf0d261eb277ae562, which came with the
following comment.
E.g., in Allegro CL, if we EXCL:DUMPLISP with SLIME running (with
SWANK:*GLOBALLY-REDIRECT-IO* enabled), we can clean things up
with SWANK:CLOSE-CONNECTION when starting from the dumped image,
except an error occurs when closing this stream since it will
point to a stale socket.
---
slynk/slynk.lisp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/slynk/slynk.lisp b/slynk/slynk.lisp
index 6217ab5..3515b23 100644
--- a/slynk/slynk.lisp
+++ b/slynk/slynk.lisp
@@ -606,8 +606,7 @@ corresponding values in the CDR of VALUE."
(clear-input in)))
(defmethod close-listener (l)
- ;; TODO: investigate why SBCL complains when we close IN and OUT
- ;; here.
+ (with-slots (in out) l (close in) (close out))
(setf (listeners) (delete l (listeners))))
@@ -1174,7 +1173,8 @@ point the thread terminates and CHANNEL is closed."
(format *log-output* "~&;; closing ~a channels~%" (length
(connection-channels c)))
(mapc #'(lambda (c) (close-channel c :force t)) (connection-channels c))
(format *log-output* "~&;; closing ~a listeners~%" (length
(connection-listeners c)))
- (mapc #'close-listener (connection-listeners c)))
+ (ignore-errors
+ (mapc #'close-listener (connection-listeners c))))
(stop-serving-requests c)
(close (connection-socket-io c))
(setf *connections* (remove c *connections*))
- [nongnu] externals/sly ae4bbca 45/47: Don't force mREPL to use channel thread for everything, (continued)
- [nongnu] externals/sly ae4bbca 45/47: Don't force mREPL to use channel thread for everything, ELPA Syncer, 2020/12/17
- [nongnu] externals/sly e927cda 47/47: Release SLY 1.0.42, ELPA Syncer, 2020/12/17
- [nongnu] externals/sly a1fc34c 03/47: Add a name to the mailbox lock for clasp, ELPA Syncer, 2020/12/17
- [nongnu] externals/sly b2732f4 15/47: Add line, column kw args to slynk-compile-string, ELPA Syncer, 2020/12/17
- [nongnu] externals/sly 5ec798d 19/47: decode-arglist: don't fall on arglist-dummy., ELPA Syncer, 2020/12/17
- [nongnu] externals/sly a0308b7 21/47: fix spurious detection of allegro modern-mode (#540), ELPA Syncer, 2020/12/17
- [nongnu] externals/sly 9392ac9 32/47: Fix collect-macro-forms in clasp, ELPA Syncer, 2020/12/17
- [nongnu] externals/sly 3c83b6f 06/47: Improve jump to source with 'v' in sldb in clasp, ELPA Syncer, 2020/12/17
- [nongnu] externals/sly c74ef16 14/47: Improve source locations for inlined code in clasp, ELPA Syncer, 2020/12/17
- [nongnu] externals/sly 463cef6 20/47: sbcl/sexp-in-bounds-p: descend into comma-expr., ELPA Syncer, 2020/12/17
- [nongnu] externals/sly 748fd92 22/47: Do close streams in CLOSE-LISTENER when closing SLYNK::LISTENER,
ELPA Syncer <=
- [nongnu] externals/sly a9502b1 25/47: abcl: fix finding slime locations within JAR archives, ELPA Syncer, 2020/12/17
- [nongnu] externals/sly afedabc 26/47: abcl: fix inspector for Java methods and fields, ELPA Syncer, 2020/12/17
- [nongnu] externals/sly edf5d52 27/47: sbcl: Filter out invalid definition sources in find-definitions, ELPA Syncer, 2020/12/17
- [nongnu] externals/sly 0abe736 28/47: Define a macro in time, ELPA Syncer, 2020/12/17