emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/ivy-hydra a37ec22 279/395: Revert "ivy.el (ivy--update-


From: Basil L. Contovounesios
Subject: [elpa] externals/ivy-hydra a37ec22 279/395: Revert "ivy.el (ivy--update-minibuffer): don't filter while there's input"
Date: Thu, 25 Feb 2021 08:32:20 -0500 (EST)

branch: externals/ivy-hydra
commit a37ec221ce7a0fce6f881d83895b8f971636cc05
Author: Oleh Krehel <ohwoeowho@gmail.com>
Commit: Oleh Krehel <ohwoeowho@gmail.com>

    Revert "ivy.el (ivy--update-minibuffer): don't filter while there's input"
    
    This reverts commit 8989ed128402bd6f75ae28c887e029be0dde94a5.
    
    The above commit broke at least `ivy-switch-buffer`, possible more commands.
    When calling `ivy-switch-buffer` and pressing "RET" as quick as possible, 
around 1 times out of 10,
    `ivy--switch-buffer-action' will be called with a nil argument.
    
    Re #2564
---
 ivy.el | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/ivy.el b/ivy.el
index e49a371..ea1870b 100644
--- a/ivy.el
+++ b/ivy.el
@@ -3500,10 +3500,8 @@ Should be run via minibuffer `post-command-hook'."
                          (ivy--buffer-list "" ivy-use-virtual-buffers)))
                  (setq ivy--old-re nil))))
         (with-current-buffer (ivy-state-buffer ivy-last)
-          (let ((ret (while-no-input
-                       (ivy--format
-                        (ivy--filter ivy-text ivy--all-candidates)))))
-            (unless (booleanp ret) ret))))
+          (ivy--format
+           (ivy--filter ivy-text ivy--all-candidates))))
     (setq ivy--old-text ivy-text)))
 
 (defun ivy-display-function-fallback (str)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]