emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/emms ba16ff6 13/80: * emms-tag-editor.el: lexical compa


From: Stefan Monnier
Subject: [elpa] externals/emms ba16ff6 13/80: * emms-tag-editor.el: lexical compatibility work
Date: Wed, 17 Mar 2021 18:42:21 -0400 (EDT)

branch: externals/emms
commit ba16ff6dedf2de5dda219cf38b1d6d092b542de6
Author: Yoni Rabkin <yoni@rabkins.net>
Commit: Yoni Rabkin <yoni@rabkins.net>

    * emms-tag-editor.el: lexical compatibility work
    
    Remove free lexical variables and the add-to-list, which really should
    only be used for user configuration work.
---
 emms-tag-editor.el | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/emms-tag-editor.el b/emms-tag-editor.el
index 0098024..52a8046 100644
--- a/emms-tag-editor.el
+++ b/emms-tag-editor.el
@@ -154,7 +154,7 @@ See also `emms-tag-editor-tag-file' and 
`emms-tag-editor-tag-ogg'.")
   (require 'emms-info-metaflac)
   (with-temp-buffer
     (let ((tags '("artist" "composer" "performer" "title" "album" 
"tracknumber" "discnumber" "date" "genre" "note"))
-         need val)
+         val)
       (mapc (lambda (tag)
               (let ((info-tag (intern (concat "info-" tag))))
                 (when (> (length (setq val (emms-track-get track info-tag))) 0)
@@ -544,7 +544,7 @@ Available tags are:
                      match "[^-]+"))
              (setq compiled (concat compiled "\\(" match "\\)")
                    index (1+ index))
-             (add-to-list 'registers (cons register index)))
+             (push (cons register index) registers))
             (t (setq compiled (concat compiled (char-to-string c))))))
     (if (/= paren 0) (error "Paren not match!"))
     (cons compiled registers)))
@@ -830,7 +830,6 @@ A pipe is defined like below:
   "Run command of pipe nameed PIPE-NAME to TRACK."
   (if (eq (emms-track-get track 'type) 'file)
       (let* ((coding-system-for-read 'utf-8)
-             (track-name (emms-track-name track))
              (command (emms-tag-editor-pipe-get pipe-name :command))
              (arguments (emms-tag-editor-pipe-get pipe-name :arguments)))
         (when (functionp arguments)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]