emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/denote 332512b144 4/4: Merge pull request #30 from ggjp


From: ELPA Syncer
Subject: [elpa] externals/denote 332512b144 4/4: Merge pull request #30 from ggjp/default-title-when-renaming
Date: Sun, 3 Jul 2022 01:57:34 -0400 (EDT)

branch: externals/denote
commit 332512b14469ccefcb0c9122f3471571da2ab73f
Merge: b76eb3e20f b4d1a73629
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: GitHub <noreply@github.com>

    Merge pull request #30 from ggjp/default-title-when-renaming
    
    Set default-value to previous title in denote--title-prompt
    
    An empty input will just use the previous title. This would be useful if
    you just want to update the tags.  When prompted for a title, using M-n
    allows for editing of the previous title.
---
 denote-dired.el |  9 +++++----
 denote.el       | 13 +++++++++----
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/denote-dired.el b/denote-dired.el
index 727de90109..53c730a205 100644
--- a/denote-dired.el
+++ b/denote-dired.el
@@ -231,10 +231,11 @@ This command is intended to (i) rename existing Denote
 notes, (ii) complement note-taking, such as by renaming
 attachments that the user adds to their notes."
   (interactive
-   (list
-    (denote-dired--rename-file-is-regular 
(denote-dired--rename-dired-file-or-prompt))
-    (denote--title-prompt)
-    (denote--keywords-prompt)))
+   (let ((file (denote-dired--rename-file-is-regular 
(denote-dired--rename-dired-file-or-prompt))))
+     (list
+      file
+      (denote--title-prompt (denote-retrieve--value-title file))
+      (denote--keywords-prompt))))
   (let* ((dir (file-name-directory file))
          (old-name (file-name-nondirectory file))
          (extension (file-name-extension file t))
diff --git a/denote.el b/denote.el
index 039a8ffd7f..909c8610e1 100644
--- a/denote.el
+++ b/denote.el
@@ -631,10 +631,15 @@ used to construct the path's identifier."
 (defvar denote--title-history nil
   "Minibuffer history of `denote--title-prompt'.")
 
-(defun denote--title-prompt ()
-  "Read file title for `denote'."
-  (setq denote-last-title
-        (read-string "File title: " nil 'denote--title-history)))
+(defun denote--title-prompt (&optional default-title)
+  "Read file title for `denote'.
+
+Optional DEFAULT-TITLE is used as the default value."
+  (let ((format (if default-title
+                    (format " File title [%s]: " default-title)
+                  "File title: ")))
+    (setq denote-last-title
+          (read-string format nil 'denote--title-history default-title))))
 
 ;;;###autoload
 (defun denote (title keywords)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]