emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] elpa-admin 8e210d8d12: * elpa-admin.el (elpaa--write-plain-readme


From: Stefan Monnier
Subject: [elpa] elpa-admin 8e210d8d12: * elpa-admin.el (elpaa--write-plain-readme): Don't use a symlink
Date: Tue, 5 Jul 2022 11:35:52 -0400 (EDT)

branch: elpa-admin
commit 8e210d8d12e2912c8933b1d1e69b872ae118ea9d
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    * elpa-admin.el (elpaa--write-plain-readme): Don't use a symlink
---
 elpa-admin.el | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/elpa-admin.el b/elpa-admin.el
index 8e2f0c9a18..ecae2795e2 100644
--- a/elpa-admin.el
+++ b/elpa-admin.el
@@ -1185,9 +1185,12 @@ readme file has an unconventional name"
         (when (and readme-file
                    (not (eq readme-file 'ignore))
                    (not (member readme-file known-readme-names)))
-          (with-demoted-errors "%S"
-            (let ((default-directory pkg-dir))
-              (make-symbolic-link readme-file "README-elpa")))
+          (let ((default-directory pkg-dir))
+            ;; It's tempting to use a symlink, but our tarballs should not
+            ;; contain symlinks (so they work under w32, for instance,
+            ;; and also because I'm not sure how well tar-untar-buffer
+            ;; handles symlinks).
+            (copy-file readme-file "README-elpa"))
           (cdr readme-content))))
      ((cdr readme-content)))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]