[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/scroll-on-jump 9c333320ea 05/31: Don't catch and re-raise
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/scroll-on-jump 9c333320ea 05/31: Don't catch and re-raise errors |
Date: |
Thu, 7 Jul 2022 12:03:12 -0400 (EDT) |
branch: elpa/scroll-on-jump
commit 9c333320eaa72689f7c79986a19e989a8015c4eb
Author: Campbell Barton <ideasman42@gmail.com>
Commit: Campbell Barton <ideasman42@gmail.com>
Don't catch and re-raise errors
this makes debugging errors difficult.
---
scroll-on-jump.el | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/scroll-on-jump.el b/scroll-on-jump.el
index 7be5edf77e..dc8472ed0c 100644
--- a/scroll-on-jump.el
+++ b/scroll-on-jump.el
@@ -401,12 +401,17 @@ Argument ALSO-MOVE-POINT When non-nil, move the POINT as
well."
(prog1
(save-excursion
- (condition-case err
+ ;; Note, we could catch and re-raise errors,
+ ;; this has the advantage that we could get the resulting cursor
location
+ ;; even in the case of an error.
+ ;; However - this makes troubleshooting problems considerably more
difficult.
+ ;; As it wont show the full back-trace, only the error message.
+ ;; So don't prioritize correct jumping in the case of errors and
assume errors
+ ;; are not something that happen after cursor motion.
+ (prog1
(progn
,@body)
- ;; Re-raise below, after handing cursor motion.
- (error (setq err-value err)))
- (setq point-next (point)))
+ (setq point-next (point))))
(when (and (eq buf (current-buffer)) (eq window (selected-window)))
(setq has-context-changed nil))
- [nongnu] elpa/scroll-on-jump 8fde237ae6 31/31: Change URL to codeberg, (continued)
- [nongnu] elpa/scroll-on-jump 8fde237ae6 31/31: Change URL to codeberg, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump a614bc7f8f 06/31: Fix the case when the windows buffer is not the current-buffer, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump 5a6f698b6f 23/31: Cleanup: replace 'if' with 'cond', ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump 1e9e09f0cc 29/31: Fix error counting lines jumping to a point outside buffer range, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump a2d6996a36 24/31: Cleanup: use defgroup, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump 7b2919f8d8 27/31: Fix smooth (pixel) scrolling not being used in most cases, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump 1f2349edf4 04/31: Fix scrolling down when the point is at the beginning of the buffer, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump e8b79d35d4 09/31: Cleanup: split scroll-on-jump--scroll-impl into it's own function, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump 028e672391 03/31: Cleanup: no need for `let*`, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump eb77ab1920 02/31: readme: add a more complete example, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump 9c333320ea 05/31: Don't catch and re-raise errors,
ELPA Syncer <=
- [nongnu] elpa/scroll-on-jump 7a51468bdd 14/31: Cleanup: declare variable, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump 0cf26a15bb 26/31: Cleanup: use window-body-height, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump df8b208ba7 16/31: readme: add melpa link, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump ea74496fa1 10/31: Fix recursive calls to animate scrolling, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump 055144ca83 12/31: Disable moving the point when the destination point doesn't move, ELPA Syncer, 2022/07/07
- [nongnu] elpa/scroll-on-jump 30e23e8694 01/31: Initial commit, ELPA Syncer, 2022/07/07