[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/inf-ruby 8894867e9d 263/265: Fix #159 by bringing back --n
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/inf-ruby 8894867e9d 263/265: Fix #159 by bringing back --noreadline |
Date: |
Sat, 9 Jul 2022 21:59:32 -0400 (EDT) |
branch: elpa/inf-ruby
commit 8894867e9dc39183104eefae7b9b51e6211e3ad2
Author: Dmitry Gutov <dgutov@yandex.ru>
Commit: Dmitry Gutov <dgutov@yandex.ru>
Fix #159 by bringing back --noreadline
---
README.md | 17 +++++------------
inf-ruby.el | 9 ++++-----
2 files changed, 9 insertions(+), 17 deletions(-)
diff --git a/README.md b/README.md
index faf3874099..e83cbf75b3 100644
--- a/README.md
+++ b/README.md
@@ -117,24 +117,17 @@ type <kbd>M-x describe-function [RET] inf-ruby-minor-mode
[RET]</kbd>.
## Bugs
-* The REPL buffer doesn't seem to react to input and your Ruby is < 2.7?
-
- Try putting the following code into your `~/.irbrc`
- (issue [#51](https://github.com/nonsequitur/inf-ruby/issues/51)):
-
-```rb
-IRB.conf[:USE_READLINE] = false if ENV['INSIDE_EMACS']
-```
-
-* If your Ruby version is 2.7+ and there is a triangle instead of prompt, or
you see a reline related error
([example](https://github.com/ruby/irb/issues/43#issuecomment-589593889)), try
putting the following in your `~/.irbrc`:
+* If there is a [triangle instead of
prompt](https://github.com/nonsequitur/inf-ruby/issues/159), or you see a
reline related error
([example](https://github.com/ruby/irb/issues/43#issuecomment-589593889)), or
your REPL simply [doesn't react to
input](https://github.com/nonsequitur/inf-ruby/issues/51), try putting the
following in your `~/.irbrc`:
```rb
IRB.conf[:USE_MULTILINE] = false if ENV['INSIDE_EMACS']
+IRB.conf[:USE_READLINE] = false if ENV['INSIDE_EMACS']
```
For most projects that `inf-ruby-console-auto` can recognize, we try
-to apply this flag automatically, but some cases remain where the
-users will have to do it manually.
+to apply this flag automatically (using command line arguments rather
+than `.irbrc`), but some cases remain where the users will have to do
+it manually.
* Pry raises ZeroDivisionError in `lib/pry/pager.rb`?
diff --git a/inf-ruby.el b/inf-ruby.el
index a3f524533e..8e70350076 100755
--- a/inf-ruby.el
+++ b/inf-ruby.el
@@ -103,10 +103,9 @@ returns a string."
:group 'inf-ruby)
(defun inf-ruby--irb-command ()
- (let ((command "irb --prompt default -r irb/completion"))
- (if (inf-ruby--irb-needs-nomultiline-p)
- (setq command (concat command " --nomultiline"))
- (setq command (concat command " --noreadline")))
+ (let ((command "irb --prompt default -r irb/completion --noreadline"))
+ (when (inf-ruby--irb-needs-nomultiline-p)
+ (setq command (concat command " --nomultiline")))
command))
(defun inf-ruby--irb-needs-nomultiline-p (&optional with-bundler)
@@ -1066,7 +1065,7 @@ automatically."
;; Note: this only has effect in Rails < 5.0 or >= 5.1.4
;; https://github.com/rails/rails/pull/29010
(when (inf-ruby--irb-needs-nomultiline-p)
- " -- --nomultiline"))
+ " -- --nomultiline --noreadline"))
"rails")))
(defun inf-ruby-console-rails-env ()
- [nongnu] elpa/inf-ruby e4ae089218 228/265: inf-ruby-console-gem: Support new IRB, (continued)
- [nongnu] elpa/inf-ruby e4ae089218 228/265: inf-ruby-console-gem: Support new IRB, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby a5b471efc0 233/265: Update document for support ruby 2.7.1, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby 067dcba3b0 234/265: Merge pull request #135 from zw963/master, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby 965df80555 235/265: Copy edits, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby b0124578db 238/265: Copy edits, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby 7593d0f355 239/265: Change ruby-send-region to send any class and module lines that enlose the definition. Also throw error it not called within a definition, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby 16c2acb458 250/265: Apply code review - use original Cider's face definition, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby 2fae1a8ba9 248/265: Change 'C-x C-e' binding to use the new command, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby 871158bcad 255/265: Merge pull request #153 from tunnes/feature-create-eval-overlay, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby 7ed2b03c95 258/265: Check specifically than IRB.conf is defined, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby 8894867e9d 263/265: Fix #159 by bringing back --noreadline,
ELPA Syncer <=
- [nongnu] elpa/inf-ruby 51ba99f6be 186/265: Proper heading for hooks, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby ec70d7f0e9 187/265: inf-ruby-buffer: Fix "wrong-type-argument stringp nil" outside of any project, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby e05cc84738 196/265: Add menu for inf-ruby-minor-mode, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby 5d7397ddd9 206/265: Add Hanami console launcher, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby 2fa228f756 210/265: Add minitest-compilation-mode to Ruby compilation modes, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby d51fdaf2ac 218/265: Resolve deprecation warnings on inf-ruby-console-rails, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby 5531aaeb89 219/265: Merge pull request #119 from abicky/fix-deprecation-warning, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby f3c927c1b9 230/265: inf-ruby--irb-needs-nomultiline-p: Handle irb or ruby absence, ELPA Syncer, 2022/07/09
- [nongnu] elpa/inf-ruby d6aa7d32ae 261/265: Merge pull request #157 from tunnes/fix-broken-behaviour-on-load-current-ruby-file-fn, ELPA Syncer, 2022/07/09