emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/inf-ruby 8894867e9d 263/265: Fix #159 by bringing back --n


From: ELPA Syncer
Subject: [nongnu] elpa/inf-ruby 8894867e9d 263/265: Fix #159 by bringing back --noreadline
Date: Sat, 9 Jul 2022 21:59:32 -0400 (EDT)

branch: elpa/inf-ruby
commit 8894867e9dc39183104eefae7b9b51e6211e3ad2
Author: Dmitry Gutov <dgutov@yandex.ru>
Commit: Dmitry Gutov <dgutov@yandex.ru>

    Fix #159 by bringing back --noreadline
---
 README.md   | 17 +++++------------
 inf-ruby.el |  9 ++++-----
 2 files changed, 9 insertions(+), 17 deletions(-)

diff --git a/README.md b/README.md
index faf3874099..e83cbf75b3 100644
--- a/README.md
+++ b/README.md
@@ -117,24 +117,17 @@ type <kbd>M-x describe-function [RET] inf-ruby-minor-mode 
[RET]</kbd>.
 
 ## Bugs
 
-* The REPL buffer doesn't seem to react to input and your Ruby is < 2.7?
-
-  Try putting the following code into your `~/.irbrc`
-  (issue [#51](https://github.com/nonsequitur/inf-ruby/issues/51)):
-
-```rb
-IRB.conf[:USE_READLINE] = false if ENV['INSIDE_EMACS']
-```
-
-* If your Ruby version is 2.7+ and there is a triangle instead of prompt, or 
you see a reline related error 
([example](https://github.com/ruby/irb/issues/43#issuecomment-589593889)), try 
putting the following in your `~/.irbrc`:
+* If there is a [triangle instead of 
prompt](https://github.com/nonsequitur/inf-ruby/issues/159), or you see a 
reline related error 
([example](https://github.com/ruby/irb/issues/43#issuecomment-589593889)), or 
your REPL simply [doesn't react to 
input](https://github.com/nonsequitur/inf-ruby/issues/51), try putting the 
following in your `~/.irbrc`:
 
 ```rb
 IRB.conf[:USE_MULTILINE] = false if ENV['INSIDE_EMACS']
+IRB.conf[:USE_READLINE] = false if ENV['INSIDE_EMACS']
 ```
 
 For most projects that `inf-ruby-console-auto` can recognize, we try
-to apply this flag automatically, but some cases remain where the
-users will have to do it manually.
+to apply this flag automatically (using command line arguments rather
+than `.irbrc`), but some cases remain where the users will have to do
+it manually.
 
 * Pry raises ZeroDivisionError in `lib/pry/pager.rb`?
 
diff --git a/inf-ruby.el b/inf-ruby.el
index a3f524533e..8e70350076 100755
--- a/inf-ruby.el
+++ b/inf-ruby.el
@@ -103,10 +103,9 @@ returns a string."
   :group 'inf-ruby)
 
 (defun inf-ruby--irb-command ()
-  (let ((command "irb --prompt default -r irb/completion"))
-    (if (inf-ruby--irb-needs-nomultiline-p)
-        (setq command (concat command " --nomultiline"))
-      (setq command (concat command "  --noreadline")))
+  (let ((command "irb --prompt default -r irb/completion --noreadline"))
+    (when (inf-ruby--irb-needs-nomultiline-p)
+      (setq command (concat command " --nomultiline")))
     command))
 
 (defun inf-ruby--irb-needs-nomultiline-p (&optional with-bundler)
@@ -1066,7 +1065,7 @@ automatically."
              ;; Note: this only has effect in Rails < 5.0 or >= 5.1.4
              ;; https://github.com/rails/rails/pull/29010
              (when (inf-ruby--irb-needs-nomultiline-p)
-               " -- --nomultiline"))
+               " -- --nomultiline --noreadline"))
      "rails")))
 
 (defun inf-ruby-console-rails-env ()



reply via email to

[Prev in Thread] Current Thread [Next in Thread]