[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/denote 218f7132bf 15/39: Remove private denote--prompts
From: |
ELPA Syncer |
Subject: |
[elpa] externals/denote 218f7132bf 15/39: Remove private denote--prompts function |
Date: |
Mon, 11 Jul 2022 00:57:44 -0400 (EDT) |
branch: externals/denote
commit 218f7132bfd0f7f756157b22a9d5c2ac61eccac1
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Remove private denote--prompts function
We no longer need it, after commits 9163443, 9dbfd37, 3f51ba3, 564c139.
Thanks to Jean-Philippe Gagné Guay for the discussion about this in
issue 41 over at the GitHub mirror:
<https://github.com/protesilaos/denote/issues/41>.
---
denote.el | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/denote.el b/denote.el
index 19858a56e1..fc04e29bac 100644
--- a/denote.el
+++ b/denote.el
@@ -689,24 +689,6 @@ Optional DEFAULT-TITLE is used as the default value."
;;;;; The `denote' command
-(defun denote--prompts ()
- "Normalize value of `denote-prompts'.
-Return a list with `title' and `keywords' as its elements if its
-value (i) is not a list (ii) is nil, (iii) does not contain the
-appropriate symbols, per `denote--prompt-symbols'."
- (let* ((prompts denote-prompts)
- (symbols denote--prompt-symbols)
- (common (seq-intersection prompts symbols)))
- (if (or (not (listp prompts))
- (null prompts)
- (null common))
- '(title keywords)
- common)))
-
-;; TODO 2022-07-07: We need to normalize or at least check with an error
-;; all the arguments that `denote' accepts when called from Lisp. Just
-;; to be sure we don't get an undesirable outcome.
-
;;;###autoload
(defun denote (&optional title keywords type date subdir)
"Create a new note with the appropriate metadata and file name.
@@ -730,7 +712,7 @@ When called from Lisp, all arguments are optional.
subdirectory must exist: Denote will not create it."
(interactive)
(when (called-interactively-p 'any)
- (dolist (prompt (denote--prompts))
+ (dolist (prompt denote-prompts)
(pcase prompt
('title (setq title (denote--title-prompt)))
('date (setq date (denote--date-prompt)))
- [elpa] externals/denote b94537cd94 14/39: Remove else part in denote--file-name-relative-to-denote-directory, (continued)
- [elpa] externals/denote b94537cd94 14/39: Remove else part in denote--file-name-relative-to-denote-directory, ELPA Syncer, 2022/07/11
- [elpa] externals/denote a285d4df6a 23/39: Merge pull request #42 from jeanphilippegg/refactor-denote-prompts, ELPA Syncer, 2022/07/11
- [elpa] externals/denote bfda1b829f 06/39: Make 'denote' use 'denote--prompts', ELPA Syncer, 2022/07/11
- [elpa] externals/denote f4c3f1c2d5 18/39: Expand denote-prompts doc string, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 71b56a6b0f 22/39: Refine interactive spec of 'denote' command, ELPA Syncer, 2022/07/11
- [elpa] externals/denote cb863db07d 25/39: Change order of arguments in 'denote', ELPA Syncer, 2022/07/11
- [elpa] externals/denote 61f48726b0 07/39: Clarify denote-prompts empty title case, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 7c36c51665 09/39: Update doc string of 'denote' command, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 60915b3104 33/39: Merge branch 'refactor-denote-prompts', ELPA Syncer, 2022/07/11
- [elpa] externals/denote fcd182f0ff 36/39: Add 'denote-directory' Info link to silos, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 218f7132bf 15/39: Remove private denote--prompts function,
ELPA Syncer <=
- [elpa] externals/denote 10e815c3fe 17/39: Refine denote-prompts Custom UI type, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 92e15886d5 20/39: Avoid errors with string value for keywords, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 5761ec5f89 34/39: BREAKING update journal samples for current 'denote', ELPA Syncer, 2022/07/11
- [elpa] externals/denote b05ea22a11 05/39: Add private function to normalise denote-prompts, ELPA Syncer, 2022/07/11
- [elpa] externals/denote d8ae24a80f 13/39: Merge branch 'main' into refactor-denote-prompts, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 8ea2a7b65d 30/39: Tweak denote-prompts doc string, ELPA Syncer, 2022/07/11
- [elpa] externals/denote d1a3fe3989 31/39: Revise manual on note creation; add denote-prompts, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 2c0727eb37 32/39: Add :link to manual in 'denote-prompts' definition, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 9cdd77d425 10/39: Add TODO for 'denote' command Lisp arguments, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 258ddc7b2c 02/39: Update denote-prompts doc string, ELPA Syncer, 2022/07/11