emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/denote 218f7132bf 15/39: Remove private denote--prompts


From: ELPA Syncer
Subject: [elpa] externals/denote 218f7132bf 15/39: Remove private denote--prompts function
Date: Mon, 11 Jul 2022 00:57:44 -0400 (EDT)

branch: externals/denote
commit 218f7132bfd0f7f756157b22a9d5c2ac61eccac1
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Remove private denote--prompts function
    
    We no longer need it, after commits 9163443, 9dbfd37, 3f51ba3, 564c139.
    
    Thanks to Jean-Philippe Gagné Guay for the discussion about this in
    issue 41 over at the GitHub mirror:
    <https://github.com/protesilaos/denote/issues/41>.
---
 denote.el | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/denote.el b/denote.el
index 19858a56e1..fc04e29bac 100644
--- a/denote.el
+++ b/denote.el
@@ -689,24 +689,6 @@ Optional DEFAULT-TITLE is used as the default value."
 
 ;;;;; The `denote' command
 
-(defun denote--prompts ()
-  "Normalize value of `denote-prompts'.
-Return a list with `title' and `keywords' as its elements if its
-value (i) is not a list (ii) is nil, (iii) does not contain the
-appropriate symbols, per `denote--prompt-symbols'."
-  (let* ((prompts denote-prompts)
-         (symbols denote--prompt-symbols)
-         (common (seq-intersection prompts symbols)))
-    (if (or (not (listp prompts))
-            (null prompts)
-            (null common))
-        '(title keywords)
-      common)))
-
-;; TODO 2022-07-07: We need to normalize or at least check with an error
-;; all the arguments that `denote' accepts when called from Lisp.  Just
-;; to be sure we don't get an undesirable outcome.
-
 ;;;###autoload
 (defun denote (&optional title keywords type date subdir)
   "Create a new note with the appropriate metadata and file name.
@@ -730,7 +712,7 @@ When called from Lisp, all arguments are optional.
   subdirectory must exist: Denote will not create it."
   (interactive)
   (when (called-interactively-p 'any)
-    (dolist (prompt (denote--prompts))
+    (dolist (prompt denote-prompts)
       (pcase prompt
         ('title (setq title (denote--title-prompt)))
         ('date (setq date (denote--date-prompt)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]