[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/denote 4cae3d4262 24/39: Rename args in 'denote' for co
From: |
ELPA Syncer |
Subject: |
[elpa] externals/denote 4cae3d4262 24/39: Rename args in 'denote' for consistency |
Date: |
Mon, 11 Jul 2022 00:57:45 -0400 (EDT) |
branch: externals/denote
commit 4cae3d42621f0d29186c5f3fe8deb9cab6518ff3
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Rename args in 'denote' for consistency
This was discussed with Jean-Philippe Gagné Guay in issue 41 over at the
GitHub mirror: <https://github.com/protesilaos/denote/issues/41>.
---
denote.el | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/denote.el b/denote.el
index feb74baf9f..f43361f73a 100644
--- a/denote.el
+++ b/denote.el
@@ -713,7 +713,7 @@ Optional DEFAULT-TITLE is used as the default value."
;;;;; The `denote' command
;;;###autoload
-(defun denote (&optional title keywords type date subdir)
+(defun denote (&optional title keywords file-type date subdirectory)
"Create a new note with the appropriate metadata and file name.
When called interactively, the metadata and file name are prompted
@@ -727,13 +727,13 @@ When called from Lisp, all arguments are optional.
- KEYWORDS is a list of strings. The list can be empty or the
value can be set to nil.
-- TYPE is a symbol among those described in `denote-file-type'.
+- FILE-TYPE is a symbol among those described in `denote-file-type'.
- DATE is a string representing a date like 2022-06-30 or a date
and time like 2022-06-16 14:30. A nil value or an empty string
is interpreted as the `current-time'.
-- SUBDIR is a string representing the path to either the value of
+- SUBDIRECTORY is a string representing the path to either the value of
the variable `denote-directory' or a subdirectory thereof. The
subdirectory must exist: Denote will not create it."
(interactive
@@ -746,12 +746,12 @@ When called from Lisp, all arguments are optional.
('date (aset args 3 (denote--date-prompt)))
('subdirectory (aset args 4 (denote--subdirs-prompt)))))
(append args nil)))
- (let* ((denote-file-type (denote--file-type-symbol (or type
denote-file-type)))
+ (let* ((denote-file-type (denote--file-type-symbol (or file-type
denote-file-type)))
(date (if (or (null date) (string-empty-p date))
(current-time)
(denote--valid-date date)))
(id (format-time-string denote--id-format date))
- (denote-directory (or subdir (denote-directory))))
+ (denote-directory (or subdirectory (denote-directory))))
(denote--barf-duplicate-id id)
(denote--prepare-note (or title "") keywords nil date id)
(denote--keywords-add-to-history keywords)))
- [elpa] externals/denote 8ea2a7b65d 30/39: Tweak denote-prompts doc string, (continued)
- [elpa] externals/denote 8ea2a7b65d 30/39: Tweak denote-prompts doc string, ELPA Syncer, 2022/07/11
- [elpa] externals/denote d1a3fe3989 31/39: Revise manual on note creation; add denote-prompts, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 2c0727eb37 32/39: Add :link to manual in 'denote-prompts' definition, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 9cdd77d425 10/39: Add TODO for 'denote' command Lisp arguments, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 258ddc7b2c 02/39: Update denote-prompts doc string, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 0326ab3d75 04/39: Add TODO for denote-prompts value, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 05e70d4e5c 11/39: Update doc strings of convenience commands, ELPA Syncer, 2022/07/11
- [elpa] externals/denote c2c0d74dc1 16/39: Fix typo in denote-prompts doc string, ELPA Syncer, 2022/07/11
- [elpa] externals/denote c56ddd3fb9 19/39: Update doc string of 'denote' command, ELPA Syncer, 2022/07/11
- [elpa] externals/denote a283cc1139 21/39: Revert "Avoid errors with string value for keywords", ELPA Syncer, 2022/07/11
- [elpa] externals/denote 4cae3d4262 24/39: Rename args in 'denote' for consistency,
ELPA Syncer <=
- [elpa] externals/denote 23cebf0fe5 26/39: Simplify 'denote' doc string about TITLE arg, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 840ffc522f 27/39: Reword and expand doc string of 'denote-prompts', ELPA Syncer, 2022/07/11
- [elpa] externals/denote 084bd4656e 28/39: Clarify interactivity for 'denote-prompts', ELPA Syncer, 2022/07/11
- [elpa] externals/denote b4b08f28e5 29/39: Improve denote-prompts reference to other commands, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 21d0485649 35/39: Update sample configuration, ELPA Syncer, 2022/07/11
- [elpa] externals/denote bce2c1b567 37/39: Fix index of 'denote' arguments, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 41600033a9 38/39: Update docs of convenience interactive commands, ELPA Syncer, 2022/07/11
- [elpa] externals/denote 089b0bea0e 39/39: Fix typo in the manual, ELPA Syncer, 2022/07/11