emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/denote ff6be0890f: Refine how 'denote:' Org link is loa


From: ELPA Syncer
Subject: [elpa] externals/denote ff6be0890f: Refine how 'denote:' Org link is loaded
Date: Wed, 13 Jul 2022 23:57:28 -0400 (EDT)

branch: externals/denote
commit ff6be0890feff8bfe309bb7bb2f227fe1308e8d1
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Refine how 'denote:' Org link is loaded
    
    This should load the setup only after Org is made available.  Whereas
    what we had before would throw an error if the user was not already
    using Org.
    
    Thanks to Abin Simon for reporting the problem and for showing how
    Elfeed handles this issue.  This was done in issue 47 on the GitHub
    mirror: <https://github.com/protesilaos/denote/issues/47>.
---
 README.org     |  8 ++++----
 denote-link.el | 25 +++++++++++++++++--------
 2 files changed, 21 insertions(+), 12 deletions(-)

diff --git a/README.org b/README.org
index 1a35a3a757..44f3b6c452 100644
--- a/README.org
+++ b/README.org
@@ -1799,10 +1799,10 @@ Denote is meant to be a collective effort.  Every bit 
of help matters.
   Cassou, Jack Baty, Jean-Philippe Gagné Guay, Kaushal Modi, Stefan
   Monnier.
 
-+ Ideas and/or user feedback :: Alan Schmitt, Alfredo Borrás, Benjamin
-  Kästner, Colin McLear, Damien Cassou, Frank Ehmsen, Jack Baty, Kaushal
-  Modi, M. Hadi Timachi, Peter Prevos, Shreyas Ragavan, Summer Emacs,
-  Sven Seebeck, Ypot, pRot0ta1p.
++ Ideas and/or user feedback :: Abin Simon, Alan Schmitt, Alfredo
+  Borrás, Benjamin Kästner, Colin McLear, Damien Cassou, Frank Ehmsen,
+  Jack Baty, Kaushal Modi, M. Hadi Timachi, Peter Prevos, Shreyas
+  Ragavan, Summer Emacs, Sven Seebeck, Ypot, pRot0ta1p.
 
 Special thanks to Peter Povinec who helped refine the file-naming
 scheme, which is the cornerstone of this project.
diff --git a/denote-link.el b/denote-link.el
index 4dd0298dd1..ae5d94dd48 100644
--- a/denote-link.el
+++ b/denote-link.el
@@ -488,14 +488,6 @@ inserts links with just the identifier."
 
 ;;;; Register `denote:' custom Org hyperlink
 
-(autoload 'org-link-set-parameters "ol.el")
-
-(org-link-set-parameters
- "denote"
- :follow #'denote-link-ol-follow
- :complete #'denote-link-ol-complete
- :export #'denote-link-ol-export)
-
 (declare-function org-link-open-as-file "ol" (path arg))
 
 (defun denote-link--ol-resolve-link-to-target (link &optional path-id)
@@ -552,5 +544,22 @@ backend."
      ((eq format 'md) (format "[%s](%s.md)" desc p))
      (t path))))
 
+;; The `eval-after-load' part with the quoted lambda is adapted from
+;; Elfeed: <https://github.com/skeeto/elfeed/>.
+
+;;;###autoload
+(eval-after-load 'org
+  `(funcall
+    ;; The extra quote below is necessary because uncompiled closures
+    ;; do not evaluate to themselves. The quote is harmless for
+    ;; byte-compiled function objects.
+    ',(lambda ()
+        (with-no-warnings
+          (org-link-set-parameters
+           "denote"
+           :follow #'denote-link-ol-follow
+           :complete #'denote-link-ol-complete
+           :export #'denote-link-ol-export)))))
+
 (provide 'denote-link)
 ;;; denote-link.el ends here



reply via email to

[Prev in Thread] Current Thread [Next in Thread]