emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/emms 061b36c562: * emms-playlist-mode.el: Prefer using


From: ELPA Syncer
Subject: [elpa] externals/emms 061b36c562: * emms-playlist-mode.el: Prefer using dired-jump
Date: Thu, 14 Jul 2022 14:57:33 -0400 (EDT)

branch: externals/emms
commit 061b36c5627706b2a7e4a636ed9644bb68e800bb
Author: Yoni Rabkin <yoni@rabkins.net>
Commit: Yoni Rabkin <yoni@rabkins.net>

    * emms-playlist-mode.el: Prefer using dired-jump
    
    * emms-playlist-mode.el (emms-playlist-mode-goto-dired-at-point): Use
    dired-jump, optionally opening the dired buffer in other-window.
    
    dired-jump behavior aligns more closely with what is advertised by the
    docstring.
---
 THANKGNU              |  1 +
 emms-playlist-mode.el | 10 ++++++----
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/THANKGNU b/THANKGNU
index ccaf4a1e23..d01be7251a 100644
--- a/THANKGNU
+++ b/THANKGNU
@@ -6,6 +6,7 @@ nevertheless much appreciated.)
 Alfred M. Szmidt        <ams@gnu.org>
 Alexis                          <flexibeast@gmail.com>
 Christian Faulhammer    <fauli@gentoo.org>
+Brian Leung              <leungbk@posteo.net>
 Dieter Deyke            <deyke@yahoo.com>
 Dirk-Jan C. Binnema     <djcb.bulk@gmail.com>
 Ian D                   <dunni@gnu.org>
diff --git a/emms-playlist-mode.el b/emms-playlist-mode.el
index a2aefcae2c..9b1f047a2d 100644
--- a/emms-playlist-mode.el
+++ b/emms-playlist-mode.el
@@ -312,15 +312,17 @@ set it as current."
           (goto-char (point-min))
           (message "Added %s" (symbol-name type)))))))
 
-(defun emms-playlist-mode-goto-dired-at-point ()
-  "Visit the track at point in a `dired' buffer."
-  (interactive)
+(defun emms-playlist-mode-goto-dired-at-point (&optional other-window)
+  "Visit the track at point in a `dired' buffer.
+
+With a prefix arg, open the `dired' buffer in OTHER-WINDOW."
+  (interactive "P")
   (let ((track (emms-playlist-track-at)))
     (if track
        (let ((name (emms-track-get track 'name))
              (type (emms-track-get track 'type)))
          (if (eq type 'file)
-             (dired (file-name-directory name))
+              (dired-jump other-window name)
            (error "Can't visit this track type in Dired")))
       (error "No track at point"))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]