[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/org-remark 94d7756949 3/3: doc: for #39 and source code
From: |
ELPA Syncer |
Subject: |
[elpa] externals/org-remark 94d7756949 3/3: doc: for #39 and source code comments |
Date: |
Mon, 18 Jul 2022 16:57:43 -0400 (EDT) |
branch: externals/org-remark
commit 94d775694969a9a25635e6e55085f6ae0cc6571e
Author: Noboru Ota <me@nobiot.com>
Commit: Noboru Ota <me@nobiot.com>
doc: for #39 and source code comments
---
NEWS | 3 +++
org-remark.el | 6 +++++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 92c897f0a8..c07164d3b9 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
+
+
Version 1.0.5 - Current
- fix #28 toggle causes error on saving highlights
+ - fix #39 source-file-name incorrect issue
Version 1.0.4
- fix: "Wrong type argument: stringp, nil" on highlightintg in scratch
diff --git a/org-remark.el b/org-remark.el
index 13b521175d..a970ca165e 100644
--- a/org-remark.el
+++ b/org-remark.el
@@ -6,7 +6,7 @@
;; URL: https://github.com/nobiot/org-remark
;; Version: 1.0.5
;; Created: 22 December 2020
-;; Last modified: 14 May 2022
+;; Last modified: 18 July 2022
;; Package-Requires: ((emacs "27.1") (org "9.4"))
;; Keywords: org-mode, annotation, writing, note-taking, marginal-notes
@@ -942,6 +942,10 @@ load the highlights"
The file name is returned by `org-remark-notes-get-file-name'.
Each highlight is a list in the following structure:
(ID (BEG . END) LABEL)"
+ ;; Set source-file-name first, as `find-file-noselect' will set the
+ ;; current-buffer to source-file-name. Issue #39 FIXME: A way to make
+ ;; this sequence agnostic is preferred, if there is a function that
+ ;; visit file but not set the current buffer
(when-let ((source-file-name (org-remark-source-get-file-name
(buffer-file-name)))
(notes-buf (find-file-noselect (org-remark-notes-get-file-name))))
;; TODO check if there is any relevant notes for the current file