emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/pyim ae16cef169: fixed minor issue of byte compile


From: ELPA Syncer
Subject: [elpa] externals/pyim ae16cef169: fixed minor issue of byte compile
Date: Thu, 28 Jul 2022 09:57:53 -0400 (EDT)

branch: externals/pyim
commit ae16cef16913999c08a35da1991514210e55be07
Author: Chen Bin <chenbin.sh@gmail.com>
Commit: Chen Bin <chenbin.sh@gmail.com>

    fixed minor issue of byte compile
    
    - @tarsius said byte compile does not "provide" any library.
      so "provide" keyword should not be used.
      see https://github.com/redguardtoo/counsel-etags/issues/85
    
    - fixed some minor typo
    
    - elint is not actually useful so it's removed
---
 Makefile                   |  7 ++-----
 tests/pyim-byte-compile.el |  5 ++---
 tests/pyim-elint.el        | 36 ------------------------------------
 3 files changed, 4 insertions(+), 44 deletions(-)

diff --git a/Makefile b/Makefile
index b89c59fc5d..6ea6f17bcb 100644
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@
 SHELL = /bin/sh
 EMACS ?= emacs
 
-.PHONY: test lint clean deps compile
+.PHONY: test clean deps compile
 
 EMACS_GENERIC_OPTS=--quick --directory . --directory .deps
 EMACS_BATCH_OPTS:=--batch $(EMACS_GENERIC_OPTS)
@@ -31,14 +31,11 @@ deps:
        @if [ ! -f .deps/pyim-basedict.el ]; then curl -L $(BASEDICT_URL) > 
.deps/pyim-basedict.el; fi;
        @if [ ! -f .deps/pyim-basedict.pyim ]; then curl -L 
$(BASEDICT_PYIM_URL) > .deps/pyim-basedict.pyim; fi;
 
-lint: deps
-       @$(EMACS) $(EMACS_BATCH_OPTS) --load ./tests/pyim-elint.el 2>&1 | grep 
-E "([Ee]rror|[Ww]arning):" && exit 1 || exit 0
-
 compile: deps
        $(RM) *.elc
        @$(EMACS) $(EMACS_BATCH_OPTS) --load ./tests/pyim-byte-compile.el 2>&1 
| grep -E "([Ee]rror|[Ww]arning):" && exit 1 || exit 0
 
-# test: lint compile deps clean
+# test: compile deps clean
 test: compile deps
        @$(EMACS) $(EMACS_BATCH_OPTS) --load ./tests/pyim-tests.el
        $(RM) pyim-tests-temp-*
diff --git a/tests/pyim-byte-compile.el b/tests/pyim-byte-compile.el
index beadf90724..50eaee4c86 100644
--- a/tests/pyim-byte-compile.el
+++ b/tests/pyim-byte-compile.el
@@ -1,4 +1,4 @@
-;;; pyim-elint.el --- syntax check the code  -*- lexical-binding: t -*-
+;;; pyim-byte-compile.el --- syntax check the code  -*- lexical-binding: t -*-
 
 ;; Copyright (C) 2022 Free Software Foundation, Inc.
 ;;
@@ -45,5 +45,4 @@
   (dolist (file files)
     (byte-compile-file file)))
 
-(provide 'pyim-byte-compile)
-;;; pyim-elint.el ends here
+;;; pyim-byte-compile.el ends here
diff --git a/tests/pyim-elint.el b/tests/pyim-elint.el
deleted file mode 100644
index 9cf1817a61..0000000000
--- a/tests/pyim-elint.el
+++ /dev/null
@@ -1,36 +0,0 @@
-;;; pyim-elint.el --- syntax check the code  -*- lexical-binding: t -*-
-
-;; Copyright (C) 2022 Free Software Foundation, Inc.
-;;
-;; Author: Chen Bin <chenbin.sh@gmail.com>
-;; URL: https://github.com/tumashu/pyim
-
-;; This file is NOT part of GNU Emacs.
-
-;; This program is free software; you can redistribute it and/or modify
-;; it under the terms of the GNU General Public License as published by
-;; the Free Software Foundation; either version 3, or (at your option)
-;; any later version.
-
-;; This program is distributed in the hope that it will be useful,
-;; but WITHOUT ANY WARRANTY; without even the implied warranty of
-;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-;; GNU General Public License for more details.
-
-;; You should have received a copy of the GNU General Public License
-;; along with this program; if not, see <https://www.gnu.org/licenses/>.
-
-;;; Commentary:
-;;  Syntax check the pyim code.  It's used in Emacs cli.
-;;
-
-;;; Code:
-(require 'elint)
-
-(let ((elint-directory-skip-re 
"\\(\\.dir-locals\\|ldefs-boot\\|loaddefs\\)\\.el\\'")
-      ;; elint can not work well with cl-defgeneric and cl-defstruct.
-      (elint-ignored-warnings '(undefined-functions)))
-  (elint-directory "."))
-
-(provide 'pyim-elint)
-;;; pyim-elint.el ends here



reply via email to

[Prev in Thread] Current Thread [Next in Thread]