emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/cider c1bd60e31d 1/3: Don't disable Gradle daemon by defau


From: ELPA Syncer
Subject: [nongnu] elpa/cider c1bd60e31d 1/3: Don't disable Gradle daemon by default
Date: Sat, 30 Jul 2022 22:58:15 -0400 (EDT)

branch: elpa/cider
commit c1bd60e31d54dd0cccf69ba8fbba64f13670c1d2
Author: Andrew Oberstar <andrew.oberstar@outlook.com>
Commit: Andrew Oberstar <andrew.oberstar@outlook.com>

    Don't disable Gradle daemon by default
    
    When Gradle support was originally added to cider in 2015, the default
    was set to disable Gradle's daemon [1] which Gradle uses to keep a warm
    JVM around to reuse for future runs.
    
    While I know there are some strong opinions about its use of a daemon,
    this is the default behavior of Gradle and I don't think we have any
    strong reasons to disable it in this case.
    
    It's possible in 2015 the daemon was less stable or more of a hog, but I
    don't believe that's true nowadays.
    
    [1] https://docs.gradle.org/current/userguide/gradle_daemon.html
---
 CHANGELOG.md | 2 ++
 cider.el     | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 703a7c5926..9dbed8e6f8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,8 @@
 
 * Upgrade injected `cider-nrepl` to 
[0.28.5](https://github.com/clojure-emacs/cider-nrepl/releases/tag/v0.28.5).
 * [#3200](https://github.com/clojure-emacs/cider/issues/3200): Improve 
cider-browse-ns interface to allow selective hiding of var types as well as 
grouping options.  Include private vars in result list.
+* Changed default `cider-gradle-command` to `./gradlew` to use the Gradle 
wrapper
+* Changed default `cider-gradle-global-options` to `""` (empty, formerly 
`--no-daemon`)
 
 ## 1.4.1 (2022-05-25)
 
diff --git a/cider.el b/cider.el
index 4614900476..8484946d68 100644
--- a/cider.el
+++ b/cider.el
@@ -196,7 +196,7 @@ By default we favor the project-specific shadow-cljs over 
the system-wide."
   :package-version '(cider . "0.10.0"))
 
 (defcustom cider-gradle-global-options
-  "--no-daemon"
+  ""
   "Command line options used to execute Gradle (e.g.: -m for dry run)."
   :type 'string
   :safe #'stringp



reply via email to

[Prev in Thread] Current Thread [Next in Thread]