[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] scratch/hyperbole 12fa8e328d 12/16: (man-show): Fix miscompilatio
From: |
Stefan Monnier |
Subject: |
[elpa] scratch/hyperbole 12fa8e328d 12/16: (man-show): Fix miscompilation |
Date: |
Mon, 19 Jun 2023 22:36:45 -0400 (EDT) |
branch: scratch/hyperbole
commit 12fa8e328d99738fe5f68f4c4a713b3581ea68da
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>
(man-show): Fix miscompilation
* hactypes.el (annot-bib): Avoid gratuitous `setq`.
(man-show): Declare `Man-notify-method` to fix miscompilation.
(rfc-toc): `select-buffer` doesn't exist.
---
hactypes.el | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/hactypes.el b/hactypes.el
index 1101ba186f..a56624fea3 100644
--- a/hactypes.el
+++ b/hactypes.el
@@ -32,14 +32,14 @@
;;; Standard Hyperbole action types
;;; ************************************************************************
-(defact annot-bib (key)
+(defact annot-bib (key) ;; FIXME: Clean up namespace use!
"Follow internal ref KEY within an annotated bibliography, delimiters=[]."
(interactive "sReference key (no []): ")
- (let ((key-regexp (concat "^[*]*[ \t]*\\[" (ebut:key-to-label key) "\\]"))
- citation)
- (if (save-excursion
- (goto-char (point-max))
- (setq citation (re-search-backward key-regexp nil t)))
+ (let* ((key-regexp (concat "^[*]*[ \t]*\\[" (ebut:key-to-label key) "\\]"))
+ (citation (save-excursion
+ (goto-char (point-max))
+ (re-search-backward key-regexp nil t))))
+ (if citation
(progn (hpath:display-buffer (current-buffer))
(goto-char citation)
(beginning-of-line))
@@ -689,6 +689,7 @@ package to display search results."
Uses `hpath:display-where' setting to control where the man page is displayed."
(interactive "sManual topic: ")
(require 'man)
+ (defvar Man-notify-method)
(let ((Man-notify-method 'meek))
(hpath:display-buffer (man topic))))
@@ -716,7 +717,7 @@ Optional SECTIONS-START limits toc entries to those after
that point."
(insert "Sections of " rfc-buf-name ":\n")
(set-buffer-modified-p nil))
(when opoint
- (select-buffer buf-name)
+ (set-buffer buf-name)
(goto-char opoint))))
(defact text-toc (section)
- [elpa] scratch/hyperbole 0bf8fd8eee 03/16: Try and avoid using `hyperb:stack-frame`, (continued)
- [elpa] scratch/hyperbole 0bf8fd8eee 03/16: Try and avoid using `hyperb:stack-frame`, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole b5780234d9 02/16: * hversion.el (hyperb:path-being-loaded): Delete function, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole 60cf4b3ab0 07/16: * hact.el: Fix broken lexical-binding cookie, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole 57d02f8456 09/16: hyperbole-autoloads.el: Remove needless definitions, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole 5aa8d7a577 10/16: * hycontrol.el (hycontrol-windows-mode-map): Don't autoload, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole fd3f79a9ee 15/16: * hargs.el (hargs:set-string-to-complete): Don't mess with windows, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole ab0338d714 05/16: Fix compilation of test file, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole 63e463172e 06/16: (kview:char-visible-p): Delete function, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole fbcfcc04a3 08/16: * hyperbole.el: Preload `kotl-autoloads`, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole fc7e33b5e5 11/16: * hui-select.el: Fix a few warnings and improve some docstrings, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole 12fa8e328d 12/16: (man-show): Fix miscompilation,
Stefan Monnier <=
- [elpa] scratch/hyperbole 10ac3f59df 13/16: Fix a few minor miscompilations and warnings, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole 02335b71bd 14/16: * hyrolo.el: A few cosmetic tweaks, Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole a269d1536e 16/16: * hversion.el: Add FIXMEs., Stefan Monnier, 2023/06/19
- [elpa] scratch/hyperbole 824a71773c 04/16: Get rid of `hyperb:stack-frame`, Stefan Monnier, 2023/06/19