emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/plz a1f8a10b0b 16/40: Comment: Add FIXME


From: ELPA Syncer
Subject: [elpa] externals/plz a1f8a10b0b 16/40: Comment: Add FIXME
Date: Mon, 26 Jun 2023 06:59:32 -0400 (EDT)

branch: externals/plz
commit a1f8a10b0b6cc57915c025a57142772145f7dc1b
Author: Adam Porter <adam@alphapapa.net>
Commit: Adam Porter <adam@alphapapa.net>

    Comment: Add FIXME
---
 plz.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/plz.el b/plz.el
index c0a61db36c..91736d4cca 100644
--- a/plz.el
+++ b/plz.el
@@ -770,6 +770,11 @@ To be called from a timer run in `plz--sentinel'."
                     (ignore status) ; Byte-compiling in Emacs <28 complains 
without this.
                     (funcall plz-then))
                    (_
+                    ;; FIXME: If using ":as 'response", the HTTP
+                    ;; response should be passed to the THEN function,
+                    ;; regardless of the status code.  Only for curl
+                    ;; errors should the ELSE function be called.
+
                     ;; Any other status code is considered unsuccessful
                     ;; (for now, anyway).
                     (let ((err (make-plz-error :response (plz--response))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]