emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/plz 260840d3e7 18/40: Change: (plz--respond) Rename fro


From: ELPA Syncer
Subject: [elpa] externals/plz 260840d3e7 18/40: Change: (plz--respond) Rename from plz--timer
Date: Mon, 26 Jun 2023 06:59:33 -0400 (EDT)

branch: externals/plz
commit 260840d3e749c2c3580eb177a3ff03b9aad1ab7d
Author: Adam Porter <adam@alphapapa.net>
Commit: Adam Porter <adam@alphapapa.net>

    Change: (plz--respond) Rename from plz--timer
    
    And improve docstring.
---
 plz.el | 28 ++++++++++++++++++----------
 1 file changed, 18 insertions(+), 10 deletions(-)

diff --git a/plz.el b/plz.el
index 27107978d3..f06be9aef8 100644
--- a/plz.el
+++ b/plz.el
@@ -731,26 +731,34 @@ node `(elisp) Sentinels').  Kills the buffer before 
returning."
         ((or 0 "finished\n")
          ;; Curl exited normally: check HTTP status code.
          (if plz-sync
-             (plz--timer process buffer status)
-           (run-at-time 0 nil #'plz--timer process buffer status)))
+             (plz--respond process buffer status)
+           (run-at-time 0 nil #'plz--respond process buffer status)))
 
         ((or (and (pred numberp) code)
              (rx "exited abnormally with code " (let code (group (1+ digit)))))
          ;; Curl error.
          (ignore code)
          (if plz-sync
-             (plz--timer process buffer status)
-           (run-at-time 0 nil #'plz--timer process buffer status)))
+             (plz--respond process buffer status)
+           (run-at-time 0 nil #'plz--respond process buffer status)))
 
         ((and (or "killed\n" "interrupt\n") status)
          ;; Curl process killed or interrupted.
          (if plz-sync
-             (plz--timer process buffer status)
-           (run-at-time 0 nil #'plz--timer process buffer status)))))))
-
-(defun plz--timer (process buffer status)
-  "Process HTTP response in BUFFER.
-To be called from a timer run in `plz--sentinel'."
+             (plz--respond process buffer status)
+           (run-at-time 0 nil #'plz--respond process buffer status)))))))
+
+(defun plz--respond (process buffer status)
+  "Respond to HTTP response from PROCESS in BUFFER.
+Parses the response and calls the THEN/ELSE callbacks
+accordingly.  To be called from `plz--sentinel'.  STATUS is the
+argument passed to `plz--sentinel', which see."
+  ;; Is it silly to call this function "please respond"?  Perhaps, but
+  ;; naming things is hard.  The term "process" has another meaning in
+  ;; this context, and the old standby, "handle," is much overused.
+  ;; "Respond" also means "to react to something," which is what this
+  ;; does--react to receiving the HTTP response--and it's an internal
+  ;; name, so why not.
   (let ((finally (buffer-local-value 'plz-finally buffer))
         sync)
     (cl-assert process nil "PROCESS IS NIL FOR BUFFER:%S" buffer)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]