emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] scratch/hyperbole a823391b89 12/12: * hversion.el (hyperb:automou


From: Stefan Monnier
Subject: [elpa] scratch/hyperbole a823391b89 12/12: * hversion.el (hyperb:automount-prefixes): Remove unused var.
Date: Tue, 27 Jun 2023 17:38:40 -0400 (EDT)

branch: scratch/hyperbole
commit a823391b89e50da43dcbe9bfcb4135c9fd7d26b6
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    * hversion.el (hyperb:automount-prefixes): Remove unused var.
    
    Also add a few FIXMEs.
---
 hmouse-drv.el |  1 +
 hversion.el   | 11 +++++------
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/hmouse-drv.el b/hmouse-drv.el
index 53de75aba8..5e6db7a51f 100644
--- a/hmouse-drv.el
+++ b/hmouse-drv.el
@@ -1627,6 +1627,7 @@ return current point as a marker."
   (and (car args) (listp (car args)) (setq args (car args)))
   (if (and args (hyperb:window-system))
       (progn (hmouse-set-point-at args) args)
+    ;; FIXME: This doesn't "Set point to ..."!?
     (list 'keyboard-drag (posn-at-point))))
 
 (defun hmouse-set-point-at (set-point-arg-list)
diff --git a/hversion.el b/hversion.el
index 4f97b60a8e..b71e9d083e 100644
--- a/hversion.el
+++ b/hversion.el
@@ -37,12 +37,6 @@
 Override this if the system-computed default is incorrect for
 your specific mouse.")
 
-(defvar hyperb:automount-prefixes
-  (if (and (boundp 'automount-dir-prefix) (stringp automount-dir-prefix))
-      automount-dir-prefix
-    "^/tmp_mnt/"
-    "Regexp to match any automounter prefix in a pathname."))
-
 ;;; ************************************************************************
 ;;; Public declarations
 ;;; ************************************************************************
@@ -75,10 +69,15 @@ Where a part in the term-type is delimited by a `-' or  an 
`_'."
     term))
 
 (defun hyperb:window-system (&optional frame)
+  ;; FIXME: This apparently can return only "emacs", "next", or nil.
+  ;; What do these things mean?  What does "window system available" mean?
+  ;; What does "mouse available mean"?
   "Return name of window system or term type where the selected FRAME is 
running.
 If nil after system initialization, no window system or mouse
 support is available."
   (unless frame (setq frame (selected-frame)))
+  ;; FIXME: Why not compute it on the fly rather than precomputing it
+  ;; via a hook and then saving it as a frame property?
   (frame-parameter frame 'hyperb:window-system))
 
 ;; Each frame could be on a different window system when under a



reply via email to

[Prev in Thread] Current Thread [Next in Thread]