emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/cider c58eebe15c 2/3: repeat integrationt tests on failure


From: ELPA Syncer
Subject: [nongnu] elpa/cider c58eebe15c 2/3: repeat integrationt tests on failure, update sesman test comments
Date: Sun, 2 Jul 2023 03:58:55 -0400 (EDT)

branch: elpa/cider
commit c58eebe15c74db5e4c3fd9a88750032c1eb2d074
Author: ikappaki <ikappaki@users.noreply.github.com>
Commit: Bozhidar Batsov <bozhidar@batsov.dev>

    repeat integrationt tests on failure, update sesman test comments
---
 .github/workflows/test.yml | 5 ++++-
 test/cider-tests.el        | 5 +++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 8fd31cd774..0e51ec25c2 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -78,4 +78,7 @@ jobs:
 
     - name: Test integration
       run: |
-        eldev -p -dtTC test --test-type integration
+        # The tests occasionally fail on macos&win in what is seems to
+        # be GH connectivity runner issues. We attempt to address this
+        # problem by rerunning the tests more than once.
+        eldev -p -dtTC test --test-type integration || eldev -p -dtTC test 
--test-type integration
diff --git a/test/cider-tests.el b/test/cider-tests.el
index 3b1425365e..8729331de2 100644
--- a/test/cider-tests.el
+++ b/test/cider-tests.el
@@ -687,8 +687,9 @@
             (setq endpoint-bef nrepl-endpoint))
 
           (sesman-restart)
-          ;; wait until a new server is brought up, i.e. the port has
-          ;; changed. It will throw if it doesn't.
+          ;; wait until a new server is brought up by continuously checking 
that
+          ;; the port has changed. If it remains the same, an exception is
+          ;; thrown, causing the test to fail.
           (nrepl-tests-poll-until (when-let ((repl (cider-current-repl)))
                                     (with-current-buffer repl
                                       (setq endpoint-aft nrepl-endpoint)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]