[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/dired-preview de9a386721 6/7: Remove asterisk from if-l
From: |
ELPA Syncer |
Subject: |
[elpa] externals/dired-preview de9a386721 6/7: Remove asterisk from if-let, when-let |
Date: |
Thu, 13 Jul 2023 15:58:00 -0400 (EDT) |
branch: externals/dired-preview
commit de9a386721c8f7ab001e209c96d6bf3f84c59461
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Remove asterisk from if-let, when-let
Those are apparently not documented in the Emacs Lisp Reference Manual
and should thus not be considered analogous to 'let*'. The 'if-let'
and 'when-let' are designed to be like 'let*'. Not sure what the
others should be in this case...
Thanks to Philip Kaludercic for pointing this out on the emacs-devel
mailing list:
<https://lists.gnu.org/archive/html/emacs-devel/2023-07/msg00406.html>.
---
dired-preview.el | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/dired-preview.el b/dired-preview.el
index 5419957cce..993cf45351 100644
--- a/dired-preview.el
+++ b/dired-preview.el
@@ -164,8 +164,8 @@ See user option `dired-preview-ignored-extensions-regexp'."
(defun dired-preview--file-displayed-p (file)
"Return non-nil if FILE is already displayed in a window."
- (when-let* ((buffer (get-file-buffer file))
- (window (get-buffer-window buffer)))
+ (when-let ((buffer (get-file-buffer file))
+ (window (get-buffer-window buffer)))
(window-live-p window)))
(defun dired-preview--set-window-parameters (window value)
@@ -232,9 +232,9 @@ checked against `split-width-threshold' or
(defun dired-preview-display-action-side ()
"Pick a side window that is appropriate for the given frame."
- (if-let* ((width (window-body-width))
- ((>= width (window-body-height)))
- ((>= width split-width-threshold)))
+ (if-let ((width (window-body-width))
+ ((>= width (window-body-height)))
+ ((>= width split-width-threshold)))
`(:side right :dimension window-width :size
,(dired-preview-get-window-size :width))
`(:side bottom :dimension window-height :size
,(dired-preview-get-window-size :height))))
@@ -301,9 +301,9 @@ With optional NO-DELAY do not start a timer. Otherwise
produce
the preview with `dired-preview-delay' of idleness."
(add-hook 'window-state-change-hook
#'dired-preview--close-previews-outside-dired)
(dired-preview--cancel-timer)
- (if-let* ((file (dired-file-name-at-point))
- ((dired-preview--preview-p file))
- ((memq this-command dired-preview-trigger-commands)))
+ (if-let ((file (dired-file-name-at-point))
+ ((dired-preview--preview-p file))
+ ((memq this-command dired-preview-trigger-commands)))
(if no-delay
(dired-preview-display-file file)
(setq dired-preview--timer
- [elpa] externals/dired-preview updated (63f6d9a2da -> 454fa6e3b4), ELPA Syncer, 2023/07/13
- [elpa] externals/dired-preview 899fb160af 3/7: Explicitly require 'seq' to work with older Emacs versions, ELPA Syncer, 2023/07/13
- [elpa] externals/dired-preview 60aaa24d8c 1/7: Simplify dired-preview--get-buffers, ELPA Syncer, 2023/07/13
- [elpa] externals/dired-preview de9a386721 6/7: Remove asterisk from if-let, when-let,
ELPA Syncer <=
- [elpa] externals/dired-preview 5da19be56a 5/7: Demote errors about where previews are run to 'user-error', ELPA Syncer, 2023/07/13
- [elpa] externals/dired-preview 454fa6e3b4 7/7: Remove needless 'and' in dired-preview--kill-buffers, ELPA Syncer, 2023/07/13
- [elpa] externals/dired-preview 94887b8ace 4/7: Use more precise types for user options, ELPA Syncer, 2023/07/13
- [elpa] externals/dired-preview f791c206e4 2/7: Add missing "Maintainer" package header, ELPA Syncer, 2023/07/13