emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/denote 4e2c795257: Fix regression in 'denote-rename-fil


From: ELPA Syncer
Subject: [elpa] externals/denote 4e2c795257: Fix regression in 'denote-rename-file'
Date: Wed, 19 Jul 2023 15:57:47 -0400 (EDT)

branch: externals/denote
commit 4e2c795257b3c43d2328b837da29f6a18d8c4e3f
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Fix regression in 'denote-rename-file'
    
    This was caused by commit bbdf360.  The idea is to not create
    duplicate identifiers while renaming files.  Though we want existing
    identifiers to be retained.
    
    Thanks to Ashton Wiersdorf for reporting the issue on the mailing
    list: 
<https://lists.sr.ht/~protesilaos/denote/%3Cm2lefbbzl1.fsf%40wiersdorfmail.net%3E>.
---
 README.org | 18 +++++++++---------
 denote.el  |  2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/README.org b/README.org
index 2a78261052..e4a96e5b1f 100644
--- a/README.org
+++ b/README.org
@@ -4508,15 +4508,15 @@ Denote is meant to be a collective effort.  Every bit 
of help matters.
   Vedang Manerikar, relict007.
 
 + Ideas and/or user feedback :: Abin Simon, Aditya Yadav, Alan
-  Schmitt, Alfredo Borrás, Benjamin Kästner, Colin McLear, Damien
-  Cassou, Elias Storms, Federico Stilman, Florian, Frank Ehmsen, Guo
-  Yong, Hanspeter Gisler, Jack Baty, Jay Rajput, Jean-Charles
-  Bagneris, Jeremy Friesen, Jonathan Sahar, Johan Bolmsjö, Juanjo
-  Presa, Kai von Fintel, Kaushal Modi, M. Hadi Timachi, Mirko
-  Hernandez, Niall Dooley, Paul van Gelder, Peter Prevos, Shreyas
-  Ragavan, Stefan Thesing, Summer Emacs, Sven Seebeck, Taoufik, Viktor
-  Haag, Wade Mealing, Yi Liu, Ypot, atanasj, doolio, drcxd, hpgisler,
-  pRot0ta1p, rbenit68, relict007, sienic, sundar bp.
+  Schmitt, Alfredo Borrás, Ashton Wiersdorf, Benjamin Kästner, Colin
+  McLear, Damien Cassou, Elias Storms, Federico Stilman, Florian,
+  Frank Ehmsen, Guo Yong, Hanspeter Gisler, Jack Baty, Jay Rajput,
+  Jean-Charles Bagneris, Jeremy Friesen, Jonathan Sahar, Johan
+  Bolmsjö, Juanjo Presa, Kai von Fintel, Kaushal Modi, M. Hadi
+  Timachi, Mirko Hernandez, Niall Dooley, Paul van Gelder, Peter
+  Prevos, Shreyas Ragavan, Stefan Thesing, Summer Emacs, Sven Seebeck,
+  Taoufik, Viktor Haag, Wade Mealing, Yi Liu, Ypot, atanasj, doolio,
+  drcxd, hpgisler, pRot0ta1p, rbenit68, relict007, sienic, sundar bp.
 
 Special thanks to Peter Povinec who helped refine the file-naming
 scheme, which is the cornerstone of this project.
diff --git a/denote.el b/denote.el
index 33e1831b54..01fb006968 100644
--- a/denote.el
+++ b/denote.el
@@ -1350,7 +1350,7 @@ To only return an existing identifier, refer to the 
function
     (cond
      ((and files (listp files))
       (denote--return-new-identifier-if-duplicate id files))
-     (files
+     ((and files (not (denote-file-has-identifier-p file)))
       (denote--return-new-identifier-if-duplicate id))
      (t
       id))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]