emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org-remark 883d0018fe 08/67: fix(save): source-setup-do


From: ELPA Syncer
Subject: [elpa] externals/org-remark 883d0018fe 08/67: fix(save): source-setup-done needs to be done in source
Date: Sat, 22 Jul 2023 06:59:00 -0400 (EDT)

branch: externals/org-remark
commit 883d0018fed7c21a5018c2fcfa88fa3343fbfe36
Author: Noboru Ota <me@nobiot.com>
Commit: Noboru Ota <me@nobiot.com>

    fix(save): source-setup-done needs to be done in source
    
    It was done in the 'current-buffer notes-buffer' form. It's the wrong
    place.
---
 org-remark.el | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/org-remark.el b/org-remark.el
index 345436b134..cf77917d2a 100644
--- a/org-remark.el
+++ b/org-remark.el
@@ -802,12 +802,11 @@ This function assumes the current buffer is the source 
buffer."
   (and org-remark-use-org-id
        (org-entry-get point "ID" :inherit)))
 
-;;; TODO Remove test function (should be implemented in
-;;; org-remark-nov.el)
+;;; TODO When design finalizes, move to top of file.  Probably should
+;;; not be a user option, and leave it to the extension developer to add
+;;; a mode-specific entry.
 (defvar org-remark-notes-create-entry-functions
-  '((nov-mode . ((1 . test/simple-headline)
-                 (2 . org-remark-highlight-save-file-entry)))
-    (default . ((1 . org-remark-highlight-save-file-entry)))))
+  '((default . ((1 . org-remark-highlight-save-file-entry)))))
 
 (defun org-remark-highlight-save (overlay source-buf notes-buf)
   "Save a single HIGHLIGHT in the marginal notes file.
@@ -874,7 +873,7 @@ buffer for automatic sync."
     (unless org-remark-source-setup-done
       (org-remark-notes-setup notes-buf source-buf))
     ;;; Return notes-props
-    notes-props)
+    notes-props))
 
 ;;; TODO remove this test function
 (defun test/simple-headline (level source-buf _notes-buf)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]