[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/org-remark 883d0018fe 08/67: fix(save): source-setup-do
From: |
ELPA Syncer |
Subject: |
[elpa] externals/org-remark 883d0018fe 08/67: fix(save): source-setup-done needs to be done in source |
Date: |
Sat, 22 Jul 2023 06:59:00 -0400 (EDT) |
branch: externals/org-remark
commit 883d0018fed7c21a5018c2fcfa88fa3343fbfe36
Author: Noboru Ota <me@nobiot.com>
Commit: Noboru Ota <me@nobiot.com>
fix(save): source-setup-done needs to be done in source
It was done in the 'current-buffer notes-buffer' form. It's the wrong
place.
---
org-remark.el | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/org-remark.el b/org-remark.el
index 345436b134..cf77917d2a 100644
--- a/org-remark.el
+++ b/org-remark.el
@@ -802,12 +802,11 @@ This function assumes the current buffer is the source
buffer."
(and org-remark-use-org-id
(org-entry-get point "ID" :inherit)))
-;;; TODO Remove test function (should be implemented in
-;;; org-remark-nov.el)
+;;; TODO When design finalizes, move to top of file. Probably should
+;;; not be a user option, and leave it to the extension developer to add
+;;; a mode-specific entry.
(defvar org-remark-notes-create-entry-functions
- '((nov-mode . ((1 . test/simple-headline)
- (2 . org-remark-highlight-save-file-entry)))
- (default . ((1 . org-remark-highlight-save-file-entry)))))
+ '((default . ((1 . org-remark-highlight-save-file-entry)))))
(defun org-remark-highlight-save (overlay source-buf notes-buf)
"Save a single HIGHLIGHT in the marginal notes file.
@@ -874,7 +873,7 @@ buffer for automatic sync."
(unless org-remark-source-setup-done
(org-remark-notes-setup notes-buf source-buf))
;;; Return notes-props
- notes-props)
+ notes-props))
;;; TODO remove this test function
(defun test/simple-headline (level source-buf _notes-buf)
- [elpa] externals/org-remark updated (41a615c9f8 -> 498354ace4), ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 08a197604c 01/67: org-noter, nov epub-reader support initial stage., ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 85bbee122f 02/67: feat: add a new file for nov.el support (WIP) #49, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 883d0018fe 08/67: fix(save): source-setup-done needs to be done in source,
ELPA Syncer <=
- [elpa] externals/org-remark 02f2ca5c7c 12/67: fix: Text cut off if the highlight spans across two lines #56, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark a2fcae8d5b 03/67: refactor(mark): save notes buf only when create/change, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark b2e0b37247 04/67: refactor(save): -highlight-save function, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 3f71f58603 05/67: feat: dynamic notes headline level - WIP with test code, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark b2d2d432dd 06/67: feat(save): per-mode options for -notes-create-entry-functions WIP, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 8e067b1813 11/67: refactor(save): -highlight-save -> -highlight-add, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 3c25682d1d 14/67: fix: typo in regression issue, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 97c5f1c8e0 15/67: fix: missing defvar org-remark-source-find-file-name-functions, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark ba8e3433e0 18/67: feat: test/find-nov-file-buffer, ELPA Syncer, 2023/07/22
- [elpa] externals/org-remark 9f95c8a6f9 22/67: refactor: adjust-positions and sync, ELPA Syncer, 2023/07/22