emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/hyperdrive d615e85fa3 01/11: Fix: (h//clean-buffer) Avoid


From: ELPA Syncer
Subject: [nongnu] elpa/hyperdrive d615e85fa3 01/11: Fix: (h//clean-buffer) Avoid native compilation error
Date: Fri, 1 Dec 2023 18:59:53 -0500 (EST)

branch: elpa/hyperdrive
commit d615e85fa35c6ca5c29b2a6fe003de5aa34fee0f
Author: Adam Porter <adam@alphapapa.net>
Commit: Adam Porter <adam@alphapapa.net>

    Fix: (h//clean-buffer) Avoid native compilation error
---
 hyperdrive-lib.el | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/hyperdrive-lib.el b/hyperdrive-lib.el
index 580bd12824..1d56760fb4 100644
--- a/hyperdrive-lib.el
+++ b/hyperdrive-lib.el
@@ -1659,15 +1659,12 @@ When PATH is nil or blank, return \"/\"."
   "Remove all local variables, overlays, and text properties in BUFFER.
 When BUFFER is nil, act on current buffer."
   (with-current-buffer (or buffer (current-buffer))
-    (if (>= emacs-major-version 29)
-        ;; FIXME: This causes a native compilation error on Emacs 28 because 
the
-        ;; call to `kill-all-local-variables' with the argument gets compiled
-        ;; even though it wouldn't get called at runtime.
-        (with-suppressed-warnings ((callargs kill-all-local-variables))
-          (kill-all-local-variables t))
-      ;; NOTE: On Emacs <29, this function will not kill permanent-local
-      ;; variables.  We're not sure if that will be a problem.
-      (kill-all-local-variables))
+    ;; TODO(deprecate-28): Call `kill-all-local-variables' with argument to 
also kill permanent-local variables.
+    ;; We're not sure if this is absolutely necessary, but it seems like a good
+    ;; idea.  But on Emacs 28 that function does not take an argument, and
+    ;; trying to do so conditionally causes a native-compilation error, so we
+    ;; omit it for now.
+    (kill-all-local-variables)
     (let ((inhibit-read-only t))
       (delete-all-overlays)
       (set-text-properties (point-min) (point-max) nil))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]