emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/pdf-tools a1048bceb2 3/3: Fix: Update PKG_CONFIG_PATH to a


From: ELPA Syncer
Subject: [nongnu] elpa/pdf-tools a1048bceb2 3/3: Fix: Update PKG_CONFIG_PATH to add glib headers
Date: Fri, 5 Apr 2024 10:03:18 -0400 (EDT)

branch: elpa/pdf-tools
commit a1048bceb2bd3f635437b0f2bfac27cae8c2dabc
Author: Vedang Manerikar <ved.manerikar@gmail.com>
Commit: Vedang Manerikar <ved.manerikar@gmail.com>

    Fix: Update PKG_CONFIG_PATH to add glib headers
    
    Copying my comment from the Github issue:
    
    > The problem is that something seems to have changed in the way brew
    > installs glib, due to which pkg-config does not find the glib headers.
    >
    > To fix this, I have updated the autobuild script to manually modify
    > the PKG_CONFIG_PATH. This should fix the problem.
    >
    > I will test the change and close this issue via the commit once I push
    > it. You will need to update your version of pdf-tools and then restart
    > Emacs to trigger the re-build again. (It might take a few hours for
    > Melpa to pick up the latest version of the pdf-tools)
    >
    > I will create a linked issue to investigate a better long-term
    > solution to this problem.
    
    Closes: #269
---
 server/autobuild | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/server/autobuild b/server/autobuild
index 92480afa99..91ee3a5211 100755
--- a/server/autobuild
+++ b/server/autobuild
@@ -362,9 +362,12 @@ os_macos() {
         PKGARGS=install
         PACKAGES="pkg-config poppler autoconf automake"
         PKG_INSTALL_AS_ROOT=
-        # brew installs libffi as keg-only, meaning we need to set
-        # PKG_CONFIG_PATH manually so configure can find it
-        export PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:$(brew --prefix 
libffi)/lib/pkgconfig/:$(brew --prefix zlib)/lib/pkgconfig/"
+        # We need to set PKG_CONFIG_PATH manually so configure can
+        # find these dependencies. I don't know why (one possible
+        # explanation has to do with 'keg-only' installs). If you do,
+        # please update:
+        # https://github.com/vedang/pdf-tools/issues/270
+        export PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:$(brew --prefix 
libffi)/lib/pkgconfig/:$(brew --prefix zlib)/lib/pkgconfig/:$(brew --prefix 
glib)/lib/pkgconfig/"
     elif which port >/dev/null 2>&1; then
         PKGCMD=port
         PKGARGS=install



reply via email to

[Prev in Thread] Current Thread [Next in Thread]