[elpa] externals/embark a6e48a4e09 1/4: fix: limit set--this-command-keys to browse-url

[ELPA Syncer]

branch: externals/embark
commit a6e48a4e09edca1f9390d8f943b8fb266b4aa905
Author: StrawberryTea <look@strawberrytea.xyz>
Commit: StrawberryTea <look@strawberrytea.xyz>

    fix: limit set--this-command-keys to browse-url
    
    My view after investigating this #470 and #182 is that the underlying
    cause is a bug in `browse-url-interactive-arg` itself, as it should
    handle `this-command-keys` being nil. However, even if that is fixed,
    older versions of Emacs will still have the issue. So I propose limiting
    the use of `set--this-command-keys` to the functions with `browse-url`
    in their name.
---
 embark.el | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/embark.el b/embark.el
index a055e90875..b1a6fde8c8 100644
--- a/embark.el
+++ b/embark.el
@@ -2070,12 +2070,15 @@ minibuffer before executing the action."
                             (embark--run-action-hooks embark-pre-action-hooks
                                                       action target quit)
                             (minibuffer-with-setup-hook inject
-                              ;; pacify commands that use (this-command-keys)
-                              (when (= (length (this-command-keys)) 0)
+                              ;; HACK work around `browse-url-interactive-arg'
+                              ;; expecting a non-empty `this-command-keys'
+                              ;; output.
+                              (when (and (eq action 'browse-url)
+                                         (= (length (this-command-keys)) 0))
                                 (set--this-command-keys
                                  (if (characterp last-command-event)
                                      (string last-command-event)
-                                  "\r")))
+                                   "\r")))
                               (setq this-command action)
                               (embark--run-around-action-hooks
                                action target quit)))