[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#60954: 29.0.60; ERC 5.4.1: loading ERC clobbers customizations t
From: |
Eli Zaretskii |
Subject: |
Re: bug#60954: 29.0.60; ERC 5.4.1: loading ERC clobbers customizations to erc-mode-hook |
Date: |
Fri, 20 Jan 2023 09:16:48 +0200 |
> Cc: emacs-erc@gnu.org
> From: "J.P." <jp@neverwas.me>
> Date: Thu, 19 Jan 2023 21:34:37 -0800
>
> I see two basic avenues of attack here. The first is a pretty safe
> stopgap and the second a slightly riskier comprehensive approach that
> should have been on the books the moment that bug was closed:
>
> hack: partially revert a tiny hunk from the commit above
>
> fix: don't require goodies at all and instead update the module
> mapping data and add all necessary autoloads and forward
> declarations
>
> Implementations of both are attached. (I didn't bother updating the
> required Compat version in the second patch, but that'd also need to
> accompany the change set.) For now, I propose we take the shorter route
> but with an eye toward revisiting the issue soon after the next (ERC)
> release. If anyone has an opinion here, now would be the time to speak
> up.
Your proposal is fine with me, thanks.