[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Fixes to inline src block execution
From: |
Eric Schulte |
Subject: |
Re: [O] [PATCH] Fixes to inline src block execution |
Date: |
Mon, 05 Sep 2011 21:31:06 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Martyn Jago <address@hidden> writes:
> Hi
>
> Some fixes to inline src block execution via org-ctrl-c-ctrl-c
> where point is beyond white-space in the inline src block body...
>
> * Start Pomodoro
> #src_emacs-lisp[:results silent]{( org-timer-set-timer 25 )}
> ^
> ,------------------------'
> | C-c C-c execution
> | was broken beyond
> | here
> `------------------
>
> Also fixes to inline src block execution where the inline src block
> happens to be on the first line of a buffer.
>
> I've included tests and test data.
>
Hi Martyn,
This looks great. I would like to apply this patch but it breaks unit
tests at least one of which existed previously and was passing. Would
you mind taking a look at these unit tests to see if your patch breaks
existing behavior?
,----[ert output from `org-test-run-all-tests']
| F test-org-babel/inline-src-blocks
| (wrong-type-argument consp nil)
|
| F test-org-babel/org-babel-get-inline-src-block-matches
| (ert-test-failed
| ((should
| (org-babel-get-inline-src-block-matches))
| :form
| (org-babel-get-inline-src-block-matches)
| :value nil))
|
| F test-org-babel/parse-header-args
| (ert-test-failed
| ((should
| (= 14
| (org-babel-execute-src-block)))
| :form
| (= 14 13)
| :value nil))
`----
Thanks! -- Eric
--
Eric Schulte
http://cs.unm.edu/~eschulte/