[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @
From: |
Bastien |
Subject: |
Re: [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)] |
Date: |
Thu, 20 Mar 2014 11:55:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Hi Nicolas,
Nicolas Richard <address@hidden> writes:
> Here's a patch. I can commit it if you like, but I don't want to do so
> without some review (it's not as trivial a change as moving the
> corresponding footnote to the other section).
I can't apply the patch, either on maint or on master, but by reading
it carefully it looks good.
Just add a missing full-stop at the end of the Changelog sentence "in
its own section.", and perhaps use `C-x 4 a' from within the diff to
include the section's name in the Changelog too.
PS: I didn't check carefully because I don't use `C' from magit, but
I assume magit may be wrong in creating Changelogs. We should report
this to magit maintainers if this is true.
--
Bastien
- [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)], Nicolas Richard, 2014/03/06
- Re: [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)], Bastien, 2014/03/13
- Re: [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)], Nicolas Richard, 2014/03/19
- Re: [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)], Nicolas Richard, 2014/03/22
- Re: [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)], Bastien, 2014/03/22
- Re: [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)], Nicolas Richard, 2014/03/22
- Re: [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)], Bastien, 2014/03/23
- Re: [O] preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)], Nicolas Richard, 2014/03/23