Re: [O] [patch] [babel] Patches to fix tangling and variable transfer of tables in R

[Rainer M Krug]

Nicolas Goaziou <address@hidden> writes:

> Hello,
>
> Rainer M Krug <address@hidden> writes:
>
>> Attached please find two patches ready for application to fix that table
>> variables were not usable adter tangling as temporary files were used.
>> These patches were discussed in the thread "[babel][PATCHES] ob-R
>> patches for review"
>
> I have not much to say about the feature, since I don't use R. Usual
> nitpicking follows.
>
>> +    (if (integerp value) (format "%s <- %s" name (concat (number-to-string 
>> value) "L"))
>> +      (if (floatp value) (format "%s <- %s" name value)
>> +    (if (stringp value) (format "%s <- %S" name value) 
>> +      (format "%s <- %S" name (prin1-to-string value)))))))
>
> I think a `cond' would be more readable here.

Agreed - my emacs lisp knowledge is growing daily...

Will send the revised patch later,

Rainer

>
>
> Regards,

-- 
Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, 
UCT), Dipl. Phys. (Germany)

Centre of Excellence for Invasion Biology
Stellenbosch University
South Africa

Tel :       +33 - (0)9 53 10 27 44
Cell:       +33 - (0)6 85 62 59 98
Fax :       +33 - (0)9 58 10 27 44

Fax (D):    +49 - (0)3 21 21 25 22 44

email:      address@hidden

Skype:      RMkrug

PGP: 0x0F52F982

pgput40E9jdPG.pgp
Description: PGP signature