[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions s
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions starting and ending a line |
Date: |
Sat, 16 Aug 2014 11:46:55 +0200 |
Hello,
Federico Beffa <address@hidden> writes:
> From the elisp manual:
> "... Advising a function can cause confusion in debugging, since people
> who debug calls to the original function may not notice that it has
> been modified with advice. Therefore, if you have the possibility to
> change the code of that function to run a hook, please solve the
> problem that way. ..."
>
> Given that people have different opinions on this, a hook would
> actually be a good idea. It would give more freedom to the users.
Advising is a good user-side mechanism, much more powerful than hooks.
Since it is /user-side/ you should know that it has been modified with
your own advice.
Anyway filling is mode's job, not user's. Again, if you want to take
over this job, use `defadvice', in your config. A hook is pointless, if
not dangerous (the task is not trivial and there are many pitfalls that
could break the structure of the document), here.
No hook in `org-fill-paragraph', please.
Regards,
--
Nicolas Goaziou 0x80A93738
Re: [O] [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions starting and ending a line, Federico Beffa, 2014/08/10