Re: [O] make orgtbl-ascii-plot easier to install

[Thierry Banel]

Hi Nicolas.

This new patch takes into account all your feedback.
Thanks again for the time spent !

Thierry


Le 28/08/2014 01:28, Nicolas Goaziou a écrit :
>
> You forgot a space at the end of the sentence. Actually, this is the
> case in all your docstrings.
Right. Fixed.

>
> Use "\\[universal-argument]" instead of "C-u".
I didn't knew this macro. Applied.

> Just to be sure to catch the following (odd) table
>
>  |--------|
>  |--------|
>  | header |
>  |--------|
>  | values |
>
> I suggest the following
>
>   (while (eq (car table) 'hline) (setq table (cdr table)))
>   (dolist (x (or (cdr (memq 'hline table)) table))
This is a strengthened algorithm, and it is shorter than the previous
version. Applied!

> The second sentence should start a new line.
Right. Fixed.

0001-Add-ascii-plotting-in-tables.patch
Description: Text Data