Re: [O] [bug] org-cycle changed behavior in orgstruct-mode

[Rasmus]

Nicolas Goaziou <address@hidden> writes:

> Rasmus <address@hidden> writes:
>
>> I tried to recompile with that line commented out but it doesn't make a
>> difference.  I also tried to remove that defun from orgstruct-setup, but
>> that also didn't make change anything.
>
> Hmm. Odd.
>>
>> If there is a way to get the buffer-string for what is actually displayed
>> in the window I could use git bisect to find the bad commit, but I don't
>> know if that is possible.
>
> See `org-copy-visible'.

Great.  The bad commit seems to be:

    commit 898cfbcac0560d1d742d939a62c5a8253fe9b66f
    Author: Nicolas Goaziou <address@hidden>
    Date:   Mon Aug 10 13:34:07 2015 +0200

        Implement faster `show-children' function

        * lisp/org.el (org-show-children): New function.
        (org-cycle-internal-local):
        (org-set-visibility-according-to-property):
        (org-content):
        (org-move-subtree-down):
        (orgstruct-setup):
        (org-show-set-visibility):
        * contrib/lisp/org-toc.el (org-toc-cycle-subtree):
        (org-toc-restore-config):
        * lisp/org-agenda.el (org-agenda-show-1):
        * lisp/org-feed.el (org-feed-update): Use new function.

        * etc/ORG-NEWS: Document new function.

        Suggested-by: Samuel Wales <address@hidden>
        <http://permalink.gmane.org/gmane.emacs.orgmode/99616>

I guess I will have to dissect it more to figure out what broke.

Here's my test.el

    (add-to-list 'load-path "~/src/code/org-mode/lisp")
    (require 'org)
    (let ((ol-rx ";;\\*+\\|\\`")
          (kill noninteractive))
      (with-temp-buffer
        (insert ";;* test
    ;;** subhead
    form1
    ")
        (set 'outline-regexp ol-rx)
        (set 'orgstruct-heading-prefix-regexp ol-rx)
        (orgstruct-mode)
        (org-global-cycle 3)
        (goto-char (point-min))
        (orgstruct-hijacker-org-cycle-4 nil)
        (let ((str (org-copy-visible (point-min) (point-max))))
          (if (string-match-p ";;\\* test\n+$" str)
              (progn (message "failed")
                     (and kill (kill-emacs 1)))
            (message "success")
            (and kill (kill-emacs 0)))
          str)))

And my test.sh

    #!/bin/sh
    emacs --batch --load test.el

Rasmus

-- 
Slowly unravels in a ball of yarn and the devil collects it