[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Add preamble support to ob-plantuml.el
From: |
Nicolas Goaziou |
Subject: |
Re: [O] Add preamble support to ob-plantuml.el |
Date: |
Mon, 05 Dec 2016 22:28:46 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hello,
Thibault Marin <address@hidden> writes:
> I am attaching a patch adding support for preamble commands to
> ob-plantuml.el. The string content of the `org-plantuml-preamble'
> variable is added at the beginning of each source block before execution
> (after the "@startuml" string).
Thank you. Some comments follow.
> TINYCHANGE
You don't need to use the TINYCHANGE string since you signed FSF papers
already.
> ---
> lisp/ob-plantuml.el | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/ob-plantuml.el b/lisp/ob-plantuml.el
> index 9ce65a9..6463585 100644
> --- a/lisp/ob-plantuml.el
> +++ b/lisp/ob-plantuml.el
> @@ -46,6 +46,12 @@
> :version "24.1"
> :type 'string)
>
> +(defcustom org-plantuml-preamble ""
> + "Preamble added at the top of every plantuml source block."
> + :group 'org-babel
> + :version "24.1"
> + :type 'string)
The :version keyword is inaccurate. It should be :version "25.2". It is
also missing :package-version and :safe #'stringp.
OOC, what is your use case?
Regards,
--
Nicolas Goaziou
- [O] Add preamble support to ob-plantuml.el, Thibault Marin, 2016/12/02
- Re: [O] Add preamble support to ob-plantuml.el,
Nicolas Goaziou <=
- Re: [O] Add preamble support to ob-plantuml.el, Thibault Marin, 2016/12/05
- Re: [O] Add preamble support to ob-plantuml.el, Nicolas Goaziou, 2016/12/06
- Re: [O] Add preamble support to ob-plantuml.el, Rainer M Krug, 2016/12/06
- Re: [O] Add preamble support to ob-plantuml.el, Thibault Marin, 2016/12/06
- Re: [O] Add preamble support to ob-plantuml.el, Nicolas Goaziou, 2016/12/09
- Re: [O] Add preamble support to ob-plantuml.el, Thibault Marin, 2016/12/09
- Re: [O] Add preamble support to ob-plantuml.el, Nicolas Goaziou, 2016/12/10
- Re: [O] Add preamble support to ob-plantuml.el, Thibault Marin, 2016/12/10
- Re: [O] Add preamble support to ob-plantuml.el, Nicolas Goaziou, 2016/12/10