[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Fix clocktable scope parameter
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] Fix clocktable scope parameter |
Date: |
Fri, 16 Dec 2016 22:11:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hello,
Eduardo Bellani <address@hidden> writes:
> The old behavior was an eval on a form if that form was not a list of
> strings. The implicit expectation was for a list of strings to be
> returned by that eval call.
>
> The above seems to be a raw attempt to evaluate a function form. In that
> case, it seems more elegant to be more explicit and do a
>
> (apply (car scope) (cdr scope))
>
>
> This also allows for passing arguments to the function without using the
> full power of eval.
>
> What do you guys think?
On the contrary, I think the above is a bit ambiguous, and doesn't bring
anything, since
:scope (foo bar baz)
can also be written, if really needed,
:scope (lambda () (foo bar baz))
I'd favor clarity here and suggest to accept a function of no argument.
Regards,
--
Nicolas Goaziou
- [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Thomas S. Dye, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/15
- Re: [O] [PATCH] Fix clocktable scope parameter,
Nicolas Goaziou <=
- Re: [O] [PATCH] Fix clocktable scope parameter, Eduardo Bellani, 2016/12/16
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/16
- Re: [O] [PATCH] Fix clocktable scope parameter, Nicolas Goaziou, 2016/12/15