[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Release 9.0.5
From: |
Nicolas Goaziou |
Subject: |
Re: [O] Release 9.0.5 |
Date: |
Mon, 13 Feb 2017 17:26:39 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hello,
Fabrice Popineau <address@hidden> writes:
> This one is about the file system which behaves differently under Windows :
>
> F test-org-export/file-uri
> Test ‘org-export-file-uri’ specifications.
> (ert-test-failed
> ((should
> (equal "file:///local.org"
> (org-export-file-uri "/local.org")))
> :form
> (equal "file:///local.org" "file://d:/local.org")
> :value nil :explanation
> (arrays-of-different-length 17 19 "file:///local.org" "file://d:/
> local.org" first-mismatch-at 7)))
>
> The absolute path has the drive name. So actually not a failure.
Ok. I rewrote the equality test. Hopefully, it should pass on your
system.
> F test-org-pcomplete/keyword
> Test keyword and block completion.
> (ert-test-failed
> ((should
> (equal "#+startup: "
> (org-test-with-temp-text "#+start<point>"
> (pcomplete)
> (buffer-string))))
> :form
> (equal "#+startup: " "#+STARTUP: ")
> :value nil :explanation
> (array-elt 2
> (different-atoms
> (115 "#x73" "?s")
> (83 "#x53" "?S")))))
>
> This one is because pcomplete is used to get completion, and the completion
> depends on
> the pcomplete-ignore-case variable, which makes pcomplete ignore case for
> windows-nt and cygwin by default.
I also fixed it.
> The last one is strange:
>
> F test-org-element/link-parser
> Test ‘link’ parser.
> (ert-test-failed
> ((should
> (equal "id"
> (org-test-with-temp-text "[[id:aaaa]]"
> (org-element-property :type ...))))
> :form
> (equal "id" "fuzzy")
> :value nil :explanation
> (arrays-of-different-length 2 5 "id" "fuzzy" first-mismatch-at 0)))
I removed this particular test. "id" links are non-standard (i.e., they
need you to require Org ID library). Such a test should go in
"test-org-id.el", which doesn't exist yet.
> This is complete non sense, because when I evaluate the test form, I
> actually get "id" and I have
> no idea where this "fuzzy" may come from.
A "fuzzy" link is a link with no default type, per
`org-link-parameters'. It probably means `org-id' wasn't loaded at the
time of the test.
> Do you also get a warning like this:
> Making org-entities-user local to *temp*-443480 while let-bound!
> in the *Messages* buffer ?
I don't.
Could you confirm tests are passing now?
Thank you.
Regards,
--
Nicolas Goaziou
Re: [O] Release 9.0.5, Russell Adams, 2017/02/10
[O] Merge 9.0.5 to emacs master? (Was: Release 9.0.5), Kaushal Modi, 2017/02/12