[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH 1/2] Add tests for org-refile-get-targets
|
From: |
Nicolas Goaziou |
|
Subject: |
Re: [O] [PATCH 1/2] Add tests for org-refile-get-targets |
|
Date: |
Mon, 22 May 2017 02:38:32 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Hello,
Sebastian Reuße <address@hidden> writes:
> Sure. Have a look at the follow-up patch and let me know what you
> think.
Thank you!
> It didn’t feel right copy-pasting the tests wholesale, so I made a
> helper-macro. I checked the ert output by forcing a failure and the
> failure explanation looks as expected. Does this work for you?
Honestly, I still find it difficult to follow and debug when one the
tests is failing. Also, we can't use `alist-get' since we are still
supporting Emacs 24.3.
Taking inspiration from your patch, I wrote a test for
`refile-get-targets' in f335c3517de06eb74a3c3727843f276147795a84. It has
more code duplication than yours. OTOH, it doesn't require any
hard-coded file. Hopefully, it will be simpler to debug when a problem
arises in the function.
Regards,
--
Nicolas Goaziou